Initialize AudioCallbackDriver::mIterationDurationMS

RESOLVED FIXED in mozilla35

Status

()

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: padenot, Assigned: padenot)

Tracking

32 Branch
mozilla35
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Assignee

Description

5 years ago
No description provided.
Assignee

Comment 1

5 years ago
10ms is a sane default, because empirically, this is what most of our platforms
run at. It will converge to the real value (if it is different from 10ms) after
a couple iterations anyways.
Attachment #8486503 - Flags: review?(rjesup)
Attachment #8486503 - Flags: review?(rjesup) → review+
This was hitting quite a few of the media tests.  Results looked like
this:

TEST-START | /tests/content/media/test/test_mediarecorder_avoid_recursion.html

Conditional jump or move depends on uninitialised value(s)
   at 0x6C860E7: mozilla::AudioCallbackDriver::DataCallback(float*, long) (content/media/GraphDriver.cpp:780)
   by 0x6C862A7: mozilla::AudioCallbackDriver::DataCallback_s(cubeb_stream*, void*, void*, long) (content/media/GraphDriver.cpp:716)
   by 0x768D33C: stream_request_callback (media/libcubeb/src/cubeb_pulse.c:195)
   by 0x3346A2C56D: create_stream_complete (/usr/src/debug/pulseaudio-1.1/src/pulse/stream.c:959)
   by 0x3346A2C56D: pa_create_stream_callback (/usr/src/debug/pulseaudio-1.1/src/pulse/stream.c:1156)
   by 0x3346E30C95: run_action (/usr/src/debug/pulseaudio-1.1/src/pulsecore/pdispatch.c:279)
   by 0x3346E3101A: pa_pdispatch_run (/usr/src/debug/pulseaudio-1.1/src/pulsecore/pdispatch.c:331)
   by 0x3346A0FDEC: pstream_packet_callback (/usr/src/debug/pulseaudio-1.1/src/pulse/context.c:335)
   by 0x3346E3583A: do_read (/usr/src/debug/pulseaudio-1.1/src/pulsecore/pstream.c:809)
   by 0x3346E3583A: do_something (/usr/src/debug/pulseaudio-1.1/src/pulsecore/pstream.c:177)
   by 0x3346A22783: dispatch_pollfds (/usr/src/debug/pulseaudio-1.1/src/pulse/mainloop.c:679)
   by 0x3346A22783: pa_mainloop_dispatch (/usr/src/debug/pulseaudio-1.1/src/pulse/mainloop.c:929)
   by 0x3346A22B34: pa_mainloop_iterate (/usr/src/debug/pulseaudio-1.1/src/pulse/mainloop.c:960)
   by 0x3346A22BDF: pa_mainloop_run (/usr/src/debug/pulseaudio-1.1/src/pulse/mainloop.c:975)
   by 0x3346A30EFE: thread (/usr/src/debug/pulseaudio-1.1/src/pulse/thread-mainloop.c:88)
   by 0x3346E43342: internal_thread_func (/usr/src/debug/pulseaudio-1.1/src/pulsecore/thread-posix.c:83)
   by 0x349F407D13: start_thread (/usr/src/debug/glibc-2.15-a316c1f/nptl/pthread_create.c:309)
   by 0x349F0F168C: clone (/usr/src/debug////////glibc-2.15-a316c1f/misc/../sysdeps/unix/sysv/linux/x86_64/clone.S:115)

 Uninitialised value was created by a heap allocation
   at 0x4809064: malloc (/home/sewardj/VgTRUNK/mozhx/coregrind/m_replacemalloc/vg_replace_malloc.c:298)
   by 0x482886B: moz_xmalloc (memory/mozalloc/mozalloc.cpp:52)
   by 0x6C97F16: operator new (ff-O-linux64/content/media/../../dist/include/mozilla/mozalloc.h:201)
   by 0x6C97F16: mozilla::MediaStreamGraphImpl::MediaStreamGraphImpl(bool, int, unsigned char, mozilla::dom::AudioChannel) (content/media/MediaStreamGraph.cpp:2728)
   by 0x6C980EF: mozilla::MediaStreamGraph::GetInstance(unsigned char, mozilla::dom::AudioChannel) (content/media/MediaStreamGraph.cpp:2785)
   by 0x6C7CB8E: mozilla::DOMMediaStream::InitTrackUnionStream(nsIDOMWindow*, unsigned char) (content/media/DOMMediaStream.cpp:231)
   by 0x68D3AD3: mozilla::nsDOMUserMediaStream::CreateTrackUnionStream(nsIDOMWindow*, mozilla::GetUserMediaCallbackMediaStreamListener*, mozilla::MediaEngineSource*, mozilla::MediaEngineSource*) (dom/media/MediaManager.cpp:509)
   by 0x68D523F: mozilla::GetUserMediaStreamRunnable::Run() (dom/media/MediaManager.cpp:766)
   by 0x58593E9: nsThread::ProcessNextEvent(bool, bool*) (xpcom/threads/nsThread.cpp:823)
   by 0x5878D71: NS_ProcessNextEvent(nsIThread*, bool) (xpcom/glue/nsThreadUtils.cpp:265)
   by 0x5AD4099: mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate*) (ipc/glue/MessagePump.cpp:99)
   by 0x5AB43CD: MessageLoop::RunInternal() (ipc/chromium/src/base/message_loop.cc:229)
   by 0x5AB43D8: MessageLoop::RunHandler() (ipc/chromium/src/base/message_loop.cc:222)
   by 0x5AB469D: MessageLoop::Run() (ipc/chromium/src/base/message_loop.cc:196)
   by 0x6AA4D0D: nsBaseAppShell::Run() (widget/xpwidgets/nsBaseAppShell.cpp:164)
   by 0x74633E3: nsAppStartup::Run() (toolkit/components/startup/nsAppStartup.cpp:280)
   by 0x74A1304: XREMain::XRE_mainRun() (toolkit/xre/nsAppRunner.cpp:4101)
> Created attachment 8486503 [details] [diff] [review]
> Initialize AudioCallbackDriver::mIterationDurationMS

Verified as stopping Valgrind from complaining.
https://hg.mozilla.org/mozilla-central/rev/fb7f1bc49963
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in before you can comment on or make changes to this bug.