Deprecate CurrentVersions, CurrentProducts and ProductsVersions api endpoints

RESOLVED FIXED

Status

Socorro
Webapp
RESOLVED FIXED
3 years ago
a year ago

People

(Reporter: peterbe, Assigned: peterbe)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
CurrentVersions is just a wrapper on top of CurrentProducts that reshuffles the output slightly. ProductsVersions is just a wrapper on top of CurrentVersions that reshuffles the output slightly. 

The goal of the models was to be a thin "port" before going into the middleware. 

But maintaining them as individual endpoint-looking things comes at a maintenance cost. Now we need to worry about three versions of API_WHITELISTs. 

We should just keep the CurrentProducts model and maybe add some utility functions that does to CurrentProducts what CurrentVersions currently does.
(Assignee)

Updated

3 years ago
Depends on: 1064608
(Assignee)

Comment 1

3 years ago
You can see here, that CurrentVersions does with the output of CurrentProducts
https://github.com/mozilla/socorro/pull/2343/files#diff-a7d1c53ffed84fe4a5fee1abc9bd61eaR250
Assignee: nobody → peterbe

Comment 2

2 years ago
See also: https://bugzilla.mozilla.org/show_bug.cgi?id=922335

We may want to close that out when this is fixed.
(Assignee)

Updated

2 years ago
Depends on: 1246256
Summary: Deprecate CurrentVersions and ProductsVersions models → Deprecate CurrentVersions, CurrentProducts and ProductsVersions api endpoints
(Assignee)

Updated

2 years ago
Depends on: 1257631
(Assignee)

Comment 3

2 years ago
Created attachment 8736311 [details]
Link to Github pull-request: https://github.com/mozilla/socorro/pull/3255#attch-to-bugzilla

Comment 4

2 years ago
Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/49a70b5f202518b4e8d1fa2ceea235a34932cfb4
fixes bug 1064968 - Deprecate CurrentVersions, CurrentProducts and ProductsVersions

https://github.com/mozilla/socorro/commit/56f65df0c7d2e8060f5d86cfac3918ca2efa4533
Merge pull request #3255 from peterbe/bug-1064968-deprecate-currentversions-currentproducts-and-productsversions-api-endpoints

fixes bug 1064968 - Deprecate CurrentVersions, CurrentProducts and Pr…

Updated

2 years ago
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
(Assignee)

Updated

a year ago
Blocks: 1311684
You need to log in before you can comment on or make changes to this bug.