All users were logged out of Bugzilla on October 13th, 2018

Add FxAccounts xpcshell tests to testing/xpcshell/xpcshell_b2g.ini

RESOLVED FIXED

Status

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: spenrose, Assigned: spenrose)

Tracking

unspecified
ARM
Gonk (Firefox OS)
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

4 years ago
Created attachment 8486517 [details] [diff] [review]
1064973-add-fxaccounts.patch

Hi Ryan!

Per https://bugzilla.mozilla.org/show_bug.cgi?id=1064606#c3 we would like to get the fxaccounts xpcshell tests run regularly. Please let me know if this is less simple than it seems.

Thanks,
Sam
Attachment #8486517 - Flags: review?(ryanvm)
Comment on attachment 8486517 [details] [diff] [review]
1064973-add-fxaccounts.patch

Review of attachment 8486517 [details] [diff] [review]:
-----------------------------------------------------------------

Yep, should be that simple. r+ assuming it's green on Try :)

Note that B2G debug xpcshell is incredibly flaky at the moment and hidden by default. You'll need to add &showall=1 to the TBPL URL to see their results. At least make sure they aren't perma-failing there (but don't expect the runs to be otherwise-green).
Attachment #8486517 - Flags: review?(ryanvm) → review+
(Assignee)

Comment 4

4 years ago
The two errors in the try are real, and fixed by these patches:

https://bugzilla.mozilla.org/show_bug.cgi?id=1064606
https://bugzilla.mozilla.org/show_bug.cgi?id=1065477
Keywords: checkin-needed
(In reply to Sam Penrose from comment #4)
> The two errors in the try are real, and fixed by these patches:
> 
> https://bugzilla.mozilla.org/show_bug.cgi?id=1064606
> https://bugzilla.mozilla.org/show_bug.cgi?id=1065477

Hi Sam, so we need to wait till bug 1065477 has r+ right ? (and so ready to checkin to unbreak the test)
Flags: needinfo?(spenrose)
Keywords: checkin-needed
(Assignee)

Comment 6

4 years ago
Hi Carsten: bug 1065477 is now r+.
Flags: needinfo?(spenrose)
https://hg.mozilla.org/mozilla-central/rev/65e0d2b2ea99
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.