Fix adbhelper for jschar change

RESOLVED FIXED

Status

RESOLVED FIXED
4 years ago
2 months ago

People

(Reporter: jryans, Assigned: jryans)

Tracking

({regression})

Firefox Tracking Flags

(Not tracked)

Details

(Assignee)

Description

4 years ago
Bug 1063962 removed jschar, which was used by adbhelper.

The addon no longer starts up and prints an error:

1410280609199	addons.xpi	WARN	Exception running bootstrap method startup on adbhelper@mozilla.org: TypeError: ctypes.jschar is undefined (resource://gre/modules/commonjs/toolkit/loader.js -> resource://adbhelperatmozilla.org/subprocess.js:196) JS Stack trace: @subprocess.js:196:7 < @adb.js:14:20 < @main.js:4:11 < startup@file:///Users/jryans/Library/Application%20Support/Firefox/Profiles/i9e2tppc.development/extensions/adbhelper@bootstrap.js:83:16 < XPI_callBootstrapMethod@XPIProvider.jsm:4303:9 < XPI_startup@XPIProvider.jsm:1966:13 < AMI_callProviders@AddonManager.jsm:872:11 < AMI_startup@AddonManager.jsm:747:1 < AMP_startup@AddonManager.jsm:2319:5 < AMC_observe@addonManager.js:55:7
(Assignee)

Updated

4 years ago
Keywords: regression
(Assignee)

Updated

4 years ago
Blocks: 1063962
(Assignee)

Comment 2

4 years ago
Released 0.5.1.
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
jryans: the ctypes.jschar alias (bug 1064935) should land today, so you can backout your adbhelper fix (maybe tomorrow to be safe?) if you'd like to simplify your addon code. :)

Updated

2 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.