Closed Bug 1065029 Opened 9 years ago Closed 9 years ago

progressbar.py test mode does not work

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla35

People

(Reporter: tromey, Assigned: tromey)

Details

Attachments

(1 file, 1 obsolete file)

import time to make test mode work
974 bytes, patch
sfink
: review+
Details | Diff | Splinter Review 
js/src/gdb/progressbar.py has a test mode, but when I tried it, it failed:

bapiya. python progressbar.py 
test           0% >                                                   |    0.0sTraceback (most recent call last):
  File "progressbar.py", line 47, in <module>
    time.sleep(0.5)
NameError: name 'time' is not defined

The bug is just a missing import.
I wasn't sure if it was worth adding a test case for this.
Attached patch a fix (obsolete) — — Splinter Review 

    
    

    
  


  

        Attachment #8488697 -
        Flags: review?(sphink)

    
  
Assignee: nobody → ttromey
Status: NEW → ASSIGNED

        Attachment #8488697 -
        Flags: review?(sphink) → review+

    
  
Keywords: checkin-needed

        Attachment #8486579 -
        Attachment is obsolete: true

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/4d7626b1425b
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Flags: qe-verify-

          You need to log in
          before you can comment on or make changes to this bug.