progressbar.py test mode does not work

RESOLVED FIXED in mozilla35

Status

()

Core
JavaScript Engine
--
trivial
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: tromey, Assigned: tromey)

Tracking

unspecified
mozilla35
x86_64
Linux
Points:
---
Bug Flags:
qe-verify -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

4 years ago
js/src/gdb/progressbar.py has a test mode, but when I tried it, it failed:

bapiya. python progressbar.py 
test           0% >                                                   |    0.0sTraceback (most recent call last):
  File "progressbar.py", line 47, in <module>
    time.sleep(0.5)
NameError: name 'time' is not defined

The bug is just a missing import.
I wasn't sure if it was worth adding a test case for this.
(Assignee)

Comment 1

4 years ago
Created attachment 8486579 [details] [diff] [review]
a fix
(Assignee)

Comment 2

4 years ago
Created attachment 8488697 [details] [diff] [review]
import time to make test mode work
Attachment #8488697 - Flags: review?(sphink)
(Assignee)

Updated

4 years ago
Assignee: nobody → ttromey
Status: NEW → ASSIGNED
Attachment #8488697 - Flags: review?(sphink) → review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
Attachment #8486579 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/4d7626b1425b
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.