1065098 - Enable leak checking for the geckomediaplugin process

Status: NEW

(Core :: Audio/Video: Playback, defect, P3)

Description

[Andrew McCreight [:mccr8]]

With my patches to make the test harness complain when a process fails to actually produce a leak log, I get this failure in M3:
  TEST-UNEXPECTED-FAIL | leakcheck | geckomediaplugin process: missing output line for total leaks!

From the log, it looks like the bloat log is being created:
### XPCOM_MEM_BLOAT_LOG defined -- logging bloat/leaks to /tmp/tmpVSWewz.mozrunner/runtests_leaks_geckomediaplugin_pid2257.log

We do have leak logs for the regular plugin process, so I'm guessing we want it here, too.  I don't know if the GMP process is crashing before it creates the log or what.

(For bug 1051230, I can just ignore failures to create leak logs for geckomediaplugin.)

Comment 1

[Andrew McCreight [:mccr8]]

(This reproduces just with dom/media/tests/mochitest/test_peerConnection_basicH264Video.html)

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

uh? Leak checking used to work in the gmp-process; I know because I run with leak checking and I had to spend some time fixing leaks in the gmp-process. Does it not now?

Comment 3

[Andrew McCreight [:mccr8]]

We have zero checking to see if a process actually produces a leak log or not (bug 831223), so if you got it working, then later somebody landed a patch that made us crash before we took a leak log, we just silently started failing.  Content process leak logging isn't working now either.  Anyways, I'm glad to hear that it was at least working at some point.

Comment 4

[Andrew McCreight [:mccr8]]

Apparently we do get a leak log sometimes.  Very odd.  See bug 1082788.

Comment 5

[Andrew McCreight [:mccr8]]

Leak checking in the geckomediaplugin process still does not work, based on a Mochitest 3 run I looked at.