Enable leak checking for the geckomediaplugin process

NEW
Unassigned

Status

()

Core
Audio/Video: Playback
3 years ago
2 years ago

People

(Reporter: mccr8, Unassigned)

Tracking

(Depends on: 1 bug)

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [MemShrink:P2])

(Reporter)

Description

3 years ago
With my patches to make the test harness complain when a process fails to actually produce a leak log, I get this failure in M3:
  TEST-UNEXPECTED-FAIL | leakcheck | geckomediaplugin process: missing output line for total leaks!

From the log, it looks like the bloat log is being created:
### XPCOM_MEM_BLOAT_LOG defined -- logging bloat/leaks to /tmp/tmpVSWewz.mozrunner/runtests_leaks_geckomediaplugin_pid2257.log

We do have leak logs for the regular plugin process, so I'm guessing we want it here, too.  I don't know if the GMP process is crashing before it creates the log or what.

(For bug 1051230, I can just ignore failures to create leak logs for geckomediaplugin.)
(Reporter)

Comment 1

3 years ago
(This reproduces just with dom/media/tests/mochitest/test_peerConnection_basicH264Video.html)
(Reporter)

Updated

3 years ago
No longer blocks: 1051230
See Also: → bug 1051230
uh? Leak checking used to work in the gmp-process; I know because I run with leak checking and I had to spend some time fixing leaks in the gmp-process. Does it not now?
(Reporter)

Comment 3

3 years ago
We have zero checking to see if a process actually produces a leak log or not (bug 831223), so if you got it working, then later somebody landed a patch that made us crash before we took a leak log, we just silently started failing.  Content process leak logging isn't working now either.  Anyways, I'm glad to hear that it was at least working at some point.
Whiteboard: [MemShrink] → [MemShrink:P2]
(Reporter)

Comment 4

3 years ago
Apparently we do get a leak log sometimes.  Very odd.  See bug 1082788.
(Reporter)

Updated

3 years ago
Depends on: 1082788, 1090201
(Reporter)

Updated

3 years ago
Depends on: 1090294
(Reporter)

Comment 5

2 years ago
Leak checking in the geckomediaplugin process still does not work, based on a Mochitest 3 run I looked at.
Component: Audio/Video → Audio/Video: Playback
You need to log in before you can comment on or make changes to this bug.