1065105 - Pinboard panel broken

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P2)

Description

[William Lachance (:wlach)]

It looks like the changes in bug 1063732 broke the pinboard, which uses absolute positioning. Probably the best long term solution is to convert the pinboard to use flexbox as well.

I will fix this.

Comment 1

[William Lachance (:wlach)]

Attachment: Fix pinboard

This doesn't look all that great, but the original had some spacing/alignment issues as well. I think the best way forward might actually be to commit this as-is, then file a followup bugs to come up with a better layout / CSS combination which makes the pinboard panel beautiful. :)

If you disagree we can iterate on this one a bit more.

Comment 2

[Cameron Dawson [:camd]]

Hey Will- This looks MUCH better.  Though the "bugs" section of the pinboard doesn't look quite right, now that I play with it.  I've attached a couple screenshots.  Maybe that panel needs a min height/width or something?

Comment 3

[Cameron Dawson [:camd]]

Attachment: with no bugs

Comment 4

[Cameron Dawson [:camd]]

Attachment: a couple bugs added

Comment 5

[Ed Morley [:emorley]]

Comment on attachment 8486778 [details] [review]
Fix pinboard

https://github.com/mozilla/treeherder-ui/commit/8c183eec78dea8642662ac8732e9f16651cbaf05

Comment 6

[William Lachance (:wlach)]

:tojonmz also noticed that the pinboard holder can expand out of control if you add a lot of jobs, we should fix that by sitting a maximum height on that container (and probably also set a minimum as it looks kinda weird if there's no jobs pinned, though that's more of an aesthetic problem than a functional one).

Comment 7

[Jonathan French (:jfrench)]

I've covered the un-pin all behavior, where the remaining 3 containers are undesirably flowing, in bug 1065636. It also describes the max container height issue there also.

Comment 8

[William Lachance (:wlach)]

Attachment: Fix sizing issues with pinboard job holder and bug list

I think this should fix the major functional issues with the pinboard. IMO we can leave everything else to followup bugs, unless I'm missing something.

Comment 9

[Ed Morley [:emorley]]

https://github.com/mozilla/treeherder-ui/commit/1b79f53a88cfc5eceec0fc067042aa88895dc4d3

Comment 10

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/fbc1bd2add136d976d7eaf1be9354ae3791e9894
Bug 1065105 - Fix pinboard by containing it within a flexbox

https://github.com/mozilla/treeherder/commit/6d27382e12868a861cf42c39d81daaf2dd276d53
Bug 1065105: More pinboard fixes

* Job entries, bug lists now have minimum/maximum heights, so things
don't contract or expand too much

https://github.com/mozilla/treeherder/commit/f4d3f67f2d974550f1d9855b1626fc40ba93d297
Merge pull request #167 from wlach/1065105-2

Bug 1065105: More pinboard fixes