Closed
Bug 1065109
Opened 10 years ago
Closed 10 years ago
Remove the MOZ_ASSERT(IsControllingDocuments()) in ServiceWorkerManager
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla35
People
(Reporter: baku, Assigned: baku)
Details
Attachments
(1 file)
|
1.02 KB,
patch
|
nsm
:
review+
|
Details | Diff | Splinter Review |
The reason why we are removing this is because any API that leaks the document would make the ServiceWorkerRegistrationInfo crash. That assert is not related to ServiceWorker API and it's better to replace the assert with a warning.
Attachment #8486748 -
Flags: review?(nsm.nikhil)
Attachment #8486748 -
Flags: review?(nsm.nikhil) → review+
|
Assignee | |
Updated•10 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Comment 1•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/f243b7ed0bec
Keywords: checkin-needed
|
||
Comment 2•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f243b7ed0bec
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•