1065142 - Make platform text selection work in non-editable fields

Status: RESOLVED INVALID

(Core :: Layout, defect)

Description

[Wesley Johnston (:wesj)]

B2G's support only works in editable fields. We want it on everywhere.

Comment 1

[Wesley Johnston (:wesj)]

ehsan, can you point us to where this is?

Comment 2

[(no longer active)]

I think this is the early return that disables the selection carets for non-editable content: <http://mxr.mozilla.org/mozilla-central/source/layout/base/SelectionCarets.cpp#415>.  You can verify this by commenting out this if block and seeing if we render the selection carets on non-editable content.

There is a similar check for touch carets: <http://mxr.mozilla.org/mozilla-central/source/layout/base/TouchCaret.cpp#177>

FWIW I think the right thing to do is to modify those two places to look at a pref and decide whether they want to disallow showing these caret types.  That way, we can set the pref to false on b2g until they decide to support these carets on non-editable content, and we can set it to true on Fennec.

CCing some of the b2g folks who have hacked on this to keep them in the loop.

Comment 3

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

I'm implementing non-editable fields support in bug 1062735.

Comment 4

[Mark Capella [:capella]]

Is this valid any longer?

Comment 5

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

We already support text selection everywhere :)