Make platform text selection work in non-editable fields

RESOLVED INVALID

Status

()

Core
Layout
RESOLVED INVALID
3 years ago
2 years ago

People

(Reporter: wesj, Unassigned)

Tracking

Trunk
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

3 years ago
B2G's support only works in editable fields. We want it on everywhere.
(Reporter)

Updated

3 years ago
Blocks: 1065138
No longer depends on: 1065138
(Reporter)

Comment 1

3 years ago
ehsan, can you point us to where this is?
Flags: needinfo?(ehsan.akhgari)

Comment 2

3 years ago
I think this is the early return that disables the selection carets for non-editable content: <http://mxr.mozilla.org/mozilla-central/source/layout/base/SelectionCarets.cpp#415>.  You can verify this by commenting out this if block and seeing if we render the selection carets on non-editable content.

There is a similar check for touch carets: <http://mxr.mozilla.org/mozilla-central/source/layout/base/TouchCaret.cpp#177>

FWIW I think the right thing to do is to modify those two places to look at a pref and decide whether they want to disallow showing these caret types.  That way, we can set the pref to false on b2g until they decide to support these carets on non-editable content, and we can set it to true on Fennec.

CCing some of the b2g folks who have hacked on this to keep them in the loop.
Component: General → Layout
Flags: needinfo?(ehsan.akhgari)
Product: Firefox for Android → Core
I'm implementing non-editable fields support in bug 1062735.
See Also: → bug 1062735
Is this valid any longer?
We already support text selection everywhere :)
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.