Closed Bug 1065172 Opened 11 years ago Closed 2 years ago

Ensure gtests compile correctly with visual studio (default windows compiler)

Categories

(NSS :: Test, defect, P5)

x86_64
Linux

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: cviecco, Unassigned)

Details

Attachments

(1 file, 3 obsolete files)

The gtests currently fail to compile on windows need to fix this so that the compilation of the tests is no longer optional.
Assignee: nobody → cviecco
Attached patch fix-compile-win-p1 (obsolete) — Splinter Review
Attached patch fix-compile-win-p1 (obsolete) — Splinter Review
Attachment #8488232 - Attachment is obsolete: true
Attached patch fix-windows-compile (obsolete) — Splinter Review
Attachment #8488268 - Attachment is obsolete: true
Attachment #8488322 - Attachment is obsolete: true
Comment on attachment 8488324 [details] [diff] [review] fix-windows-compile (1.1) Review of attachment 8488324 [details] [diff] [review]: ----------------------------------------------------------------- This allows compilation under VS 2013 of the gtests.
Attachment #8488324 - Flags: review?(rrelyea)
Assignee: cviecco → nobody
Severity: normal → S3
Severity: S3 → S4
Status: NEW → RESOLVED
Closed: 2 years ago
Priority: -- → P5
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: