1065179 - [System] App authentication page is broken

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Kevin Grandon :kgrandon]

It seems that we've broken the app authentication page by forgetting to port an instance of the <header> element in the system app.

Comment 1

[Kevin Grandon :kgrandon]

[Blocking Requested - why for this release]: We can't ship with a broken authentication dialog.

Comment 2

[Kevin Grandon :kgrandon]

Attachment: Github pull request

Wilson - could you review this one? Thanks!

Comment 3

[Wilson Page [:wilsonpage]]

Comment on attachment 8486856 [details] [review]
Github pull request

Code looks good. Thanks for spotting this Kevin, I knew there would be some parts in System I'd miss.

Comment 4

[Kevin Grandon :kgrandon]

In master: https://github.com/mozilla-b2g/gaia/commit/a004b664b88e49f3ffb84ae534578f3ee1211ef8

Comment 5

[Kevin Grandon :kgrandon]

Comment on attachment 8486856 [details] [review]
Github pull request

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Caused by gaia-header feature work.
[User impact] if declined: All authentication dialogs are broken.
[Testing completed]: Manual verification on a device.
[Risk to taking this patch] (and alternatives if risky): Low risk, it's already broken.
[String changes made]: None.

Comment 6

[bhavana bajaj [:bajaj]]

Comment on attachment 8486856 [details] [review]
Github pull request

surely not shipping with this one!

Comment 7

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/2be93a1f8d803cb60acda60d50ffb45e0a994e40

Comment 8

[Kevin Grandon :kgrandon]

Attachment: Pull request - add test case

Alberto - could you help me review this one? Thanks!

Comment 9

[Alberto Pastor [:albertopq]]

Comment on attachment 8507577 [details] [review]
Pull request - add test case

Looks good to me. Small comment in GH. Thanks!

Comment 10

[Kevin Grandon :kgrandon]

(In reply to Alberto Pastor [:albertopq] from comment #9)
> Comment on attachment 8507577 [details] [review]
> Pull request - add test case
> 
> Looks good to me. Small comment in GH. Thanks!

I didn't see the comment, but let me know if there's anything else that needs a follow-up here and I will commit it. Thanks!

Test in master: https://github.com/mozilla-b2g/gaia/commit/dbe342b893204f4d097ff65535e85c7df8237def

Comment 11

[Lancy(Leave from Mozilla)]

Hi Kevin,

Could you please provide the detailed reproduce steps for me to verify this bug.
Thank you very much!

Comment 12

[Kevin Grandon :kgrandon]

You need to go to any webpage which requires authentication. To verify it just has to look ok and function. 

Perhaps clicking the "Display Image" link on this page might work? http://www.httpwatch.com/httpgallery/authentication/

Comment 13

[Lancy(Leave from Mozilla)]

Attachment: Verify_Video_Flame v2.1.MP4

This issue has been verified successfully on Flame 2.1& 2.2.
 
1.Launch Browser and enter "http://www.httpwatch.com/httpgallery/authentication/".
2.Click "Display Image".

Actual result: An authentication request page is displayed.

See attachment: Verify_Video_Flame v2.1.MP4
Reproducing rate: 0/10

Flame v2.1 version:
Gaia-Rev        8ae086c39011bc8842b2a19bb5267906fa22345a
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/ebbd5c65c3c1
Build-ID        20141124094013
Version         34.0

Flame 2.2 version:
Gaia-Rev        aad40f6d6eb8f626c6a20db55b9f00d2e832f113
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/be4ba3d5ca9a
Build-ID        20141124100136
Version         36.0a1