1065184 - Upgrade puppet to 3.7.0

Status: RESOLVED FIXED

(Infrastructure & Operations :: RelOps: Puppet, task)

Description

[Jake Watkins [:dividehex]]

Looks like we will need to move to puppet 3.7.0 to support OSX 10.10 Yosemite
I ran into this bug will testing 10.10 in Deploystudio

Sep  9 17:11:29 t-mavericks-r5-003.test.releng.scl3.mozilla.com puppet-agent[345]: Puppet does not support OS X versions < 10.5

https://tickets.puppetlabs.com/browse/PUP-2577

Comment 1

[Jake Watkins [:dividehex]]

facter-2.2.0.dmg and puppet-3.7.0.dmg have been dropped onto relabs-puppet2.relabs

Comment 2

[Jake Watkins [:dividehex]]

Both yum and apt puppetlabs repos have been updated on relabs-puppet2.relabs.

Comment 3

[Dustin J. Mitchell [:dustin] (he/him)]

I disabled repository syncing from the moco repos, which had overwritten the indexes for those repos in relabs.  After re-syncing, upgrading and downgrading to the new puppet/facter versions seems very smooth (with the usual issue that puppet can't downgrade itself on a puppetmaster)

Comment 4

[Dustin J. Mitchell [:dustin] (he/him)]

Relabs has no mac minis, so I'll need to grab some from production to test.

Comment 5

[Dustin J. Mitchell [:dustin] (he/him)]

10.6 -- :thumbsup:
10.7 -- :thumbsup:
10.8 -- :thumbsup:
10.9 -- :shrug:
10.10 -- up to jake :)

Comment 6

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: bug1065184.patch

I had a look at the release notes too and nothing caught my eye.  Did I miss anything in testing?

I'll sync the repos over now, so they're ready to go when this is r+'d.

Comment 7

[Dustin J. Mitchell [:dustin] (he/him)]

I plan to land this a bit later today.

Comment 8

[Dustin J. Mitchell [:dustin] (he/him)]

.. and something came up yesterday, so *today*

Comment 9

[Dustin J. Mitchell [:dustin] (he/him)]

Tested on CentOS-6.2, too, since I don't remember if I tested that before.

New agents work fine against the old master, but I'll make manual puppet runs on all of the masters just in case.

Comment 10

[Dustin J. Mitchell [:dustin] (he/him)]

That didn't work very well.  The masters failed to upgrade with

Notice: /Stage[main]/Packages::Puppet/Package[facter]/ensure: ensure changed '2.0.2-1.el6' to '2.2.0-1.el6'
Error: Could not update: Failed to update to version 3.7.0-1.el6, got version 3.7.1-1.el6 instead
Wrapped exception:
Failed to update to version 3.7.0-1.el6, got version 3.7.1-1.el6 instead
Error: /Stage[main]/Packages::Puppet/Package[puppet]/ensure: change from 3.6.1-1.el6 to 3.7.0-1.el6 failed: Could not update: Failed to update to version 3.7.0-1.el6, got version 3.7.1-1.el6 instead
Notice: /Stage[main]/Packages::Puppetserver/Package[puppet-server]: Dependency Package[puppet] has failures: true
Warning: /Stage[main]/Packages::Puppetserver/Package[puppet-server]: Skipping because of failed dependencies
Notice: Finished catalog run in 60.25 seconds

I think this is due to the bidirectional dependency between puppet and puppet-server, proving once again that puppet sucks at pinning because it doesn't batch package operations (PUP-146).

After downgrading,

Error: Could not retrieve catalog from remote server: Error 400 on SERVER: undefined method `find_file' for Puppet::Parser::Files:Module at /etc/puppet/production/modules/timezone/manifests/init.pp:15 on node releng-puppet1.srv.releng.scl3.mozilla.com
Warning: Not using cache on failed catalog
Error: Could not retrieve catalog; skipping run

but a `service httpd restart` fixed this.