106524 - optgroup does not appear disabled when it is

Status: VERIFIED FIXED

(Core :: Layout: Form Controls, defect)

Description

[James Mohler]

HTML 4.01 standard clearly has the ability to disable an option group.

http://www.w3.org/TR/html4/interact/forms.html#edef-OPTGROUP

Yet items in the option group are sold black. Disabling a single item turn that
item gray.

Furthermore, the first item in the select appears selected even though it is
disable via optgroup AND option

Comment 1

[James Mohler]

Attachment: Screenshot of a problem optgroup

Comment 2

[James Mohler]

Attachment: HTML source file for screenshot

Comment 3

[Boris Zbarsky [:bzbarsky]]

The disabling should be a simple change to forms.css.  The fact that it's
selected is more serious.  jkeiser?  :) What does this look like on the branch?
 Is it just a dup of bug 92466?  If so, we should make this bug about the visual
appearance only...

Comment 4

[John Keiser (jkeiser)]

It *is* a simple fix to the CSS file, but I think we should hold off on making
optgroups *appear* disabled until they actually *can* be disabled :)  It is,
however, in the bug 34297 patch.  I think it's probably a dup of another bug
(optgroups cannot be disabled) but I'll let you be the judge.  I don't have time
to find that bug right now and will be offline for the next few days, so if you
or someone else could do so that'd be right pleasant :)  I think it's one of the
blocked bugs in 34297.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Ok.  Thanks.  Just give me a heads-up once optgroups can be disabled and then
I'll make them look so.  :)

Comment 6

[James Mohler]

This bug is similar to bug 92466 but not exactly the the same. 92466 concerns a
select with a size and multiple where as this is a more standard <select>

More importantly on this one an item appears selected by default is one that
cannot be selected.

Perhaps this is a "depends on" though?

Comment 7

[Boris Zbarsky [:bzbarsky]]

To clarify.  The bug about disabled things being selectable is bug 34297
(because the patch there fixes that problem).  This bug is being focused on
exactly what the summary says: the visual presentation.  Adding dependency.

Comment 8

[John Keiser (jkeiser)]

Someone with a non-Linux build verify please?  Should be fixed.

Comment 9

[Boris Zbarsky [:bzbarsky]]

Ok... With current solaris build I see the options disabled correctly ("two" is
selected by default) and the colors are right (the whole disabled optgroup is in
gray).

Marking fixed by jkeiser's landing.

Comment 10

[Madhur Bhatia]

i still see the bug on 
win2k buildID: 2001-11-19-06trunk & 2001-11-20-03-0.9.6 
linux 7.1 buildID: 2001-11-20-08trunk

option "one.one" under the disabled optgroup "this stuff" is selected by default 
when the testcase is loaded. This should not be the case since the optgroup has 
been set to be disabled.

reopening bug

Comment 11

[Boris Zbarsky [:bzbarsky]]

Hrm.... yep.  Fails for me on Linux.  Even fails in the same build that worked
on Solaris.  Over to jkeiser.

Comment 12

[John Keiser (jkeiser)]

Attachment: Fix

The problem actually *does* turn out to be simple.  Specifically, it is not
calling the IsOptionDisabled() method which goes through and checks optgroups.

Comment 13

[Johnny Stenback (:jst)]

Comment on attachment 58663 [details] [diff] [review]
Fix

sr=jst

Comment 14

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 58663 [details] [diff] [review]
Fix

r=bzbarsky

Comment 15

[John Keiser (jkeiser)]

Fix checked in.

Comment 16

[Madhur Bhatia]

verified fixed on 
win2k buildID: 2001-12-20-09trunk
redhat linux 7.1 buildID: 2001-12-20-08trunk
macOS 9.1 buildID: 2001-12-20-06trunk