Closed Bug 1065241 Opened 8 years ago Closed 8 years ago

gfx/layers/composite/ContainerLayerComposite.cpp:39:63: fatal error: ProfilerMarkers.h: No such file or directory (non-SPS)

Categories

(Core :: Graphics: Layers, defect)

Product:
Core
Component:
Graphics: Layers
Platform:
All
FreeBSD
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla35

People

(Reporter: jbeich, Assigned: jbeich)

References

Details

Attachments

(1 file)

ifdef out
2.56 KB, patch
mchang
: review+
Details | Diff | Splinter Review 
On platforms lacking SPS profiler (Linux/PPC, BSDs, Solaris) the build is broken because only GeckoProfiler.h is exported under tools/profiler/.

In file included from obj/gfx/layers/Unified_cpp_gfx_layers3.cpp:80:
gfx/layers/composite/ContainerLayerComposite.cpp:39:10: fatal error:
      'ProfilerMarkers.h' file not found
#include "ProfilerMarkers.h"            // for ProfilerMarkers
         ^
1 error generated.
config/rules.mk:948: recipe for target 'Unified_cpp_gfx_layers3.o' failed
gmake[1]: *** [Unified_cpp_gfx_layers3.o] Error 1
gmake[1]: Leaving directory 'gfx/layers'

http://mozillaproject.osuosl.org:8010/builders/runtests/builds/2070/steps/shell/logs/stdio
See Also: → 1065251
Attached patch ifdef out — — Splinter Review
Attachment #8486993 - Flags: review?(mchang)
Comment on attachment 8486993 [details] [diff] [review]
ifdef out

Review of attachment 8486993 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for finding this and getting to it so fast. LGTM
Attachment #8486993 - Flags: review?(mchang) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/b68b5511f401
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in before you can comment on or make changes to this bug.