1065423 - Please enable nightly builds on Maple

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[(no longer active)]

We're going to need these builds soon in order to let people experiment with service workers.  CCing Johnny and Andrew so that they can update this with more detailed priority info.

Comment 1

[Andrew Overholt [:overholt]]

Yeah, we're not there yet (in fact, we have a build failures with opt builds ATM).  But soon we'll have more functionality and giving people builds that will update as more lands will immensely help dogfooding and feedback.

Comment 2

[Justin Wood (:Callek)]

adding ben and nick since we'll need to care how updates will work on these nightlies before we can enable.

Comment 3

[[e-mail] (:bhearsum)]

Add a rule in Balrog (https://aus4-admin.mozilla.org/rules.html) after the first Nightly completes. I'm happy to show someone how to do that.

Comment 4

[Justin Wood (:Callek)]

(In reply to Ben Hearsum [:bhearsum] from comment #3)
> Add a rule in Balrog (https://aus4-admin.mozilla.org/rules.html) after the
> first Nightly completes. I'm happy to show someone how to do that.

I thought something needed to change in-tree as well...

Comment 5

[[e-mail] (:bhearsum)]

(In reply to Justin Wood (:Callek) from comment #4)
> (In reply to Ben Hearsum [:bhearsum] from comment #3)
> > Add a rule in Balrog (https://aus4-admin.mozilla.org/rules.html) after the
> > first Nightly completes. I'm happy to show someone how to do that.
> 
> I thought something needed to change in-tree as well...

No, that's already changed: https://mxr.mozilla.org/mozilla-central/source/browser/app/profile/firefox.js#145

Comment 6

[Andrew Overholt [:overholt]]

(In reply to Ben Hearsum [:bhearsum] from comment #3)
> Add a rule in Balrog (https://aus4-admin.mozilla.org/rules.html) after the
> first Nightly completes. I'm happy to show someone how to do that.

Do you mean after the first all-green build?  Also, https://aus4-admin.mozilla.org/rules.html isn't accessible for me (I'm not in an office or on the VPN).  Is that expected?  If I were to be able to access it, would it be clear to me how to add a rule in Balrog?  (Sorry, I don't know how this stuff works :)

Comment 7

[[e-mail] (:bhearsum)]

(In reply to Andrew Overholt [:overholt] from comment #6)
> (In reply to Ben Hearsum [:bhearsum] from comment #3)
> > Add a rule in Balrog (https://aus4-admin.mozilla.org/rules.html) after the
> > first Nightly completes. I'm happy to show someone how to do that.
> 
> Do you mean after the first all-green build?

The first job that managed to upload update metadata to Balrog - so likely the first green build.

> Also,
> https://aus4-admin.mozilla.org/rules.html isn't accessible for me (I'm not
> in an office or on the VPN).  Is that expected?  If I were to be able to
> access it, would it be clear to me how to add a rule in Balrog?  (Sorry, I
> don't know how this stuff works :)

Yeah, this is a RelEng managed system - it's expected that you don't have access. That part was meant for Callek.

Comment 8

[Andrew Overholt [:overholt]]

(In reply to Ben Hearsum [:bhearsum] from comment #7)
> (In reply to Andrew Overholt [:overholt] from comment #6)
> > (In reply to Ben Hearsum [:bhearsum] from comment #3)
> > > Add a rule in Balrog (https://aus4-admin.mozilla.org/rules.html) after the
> > > first Nightly completes. I'm happy to show someone how to do that.
> > 
> > Do you mean after the first all-green build?
> 
> The first job that managed to upload update metadata to Balrog - so likely
> the first green build.

There have been a few green builds now.  I downloaded one yesterday and just checked and it said there are no updates available.  Is that expected or should I have been presented with one?

Comment 9

[Justin Wood (:Callek)]

Attachment: [configs] v1 - make maple have nightlies

So after chatting with ben and looking we need Maple to have nightlies itself, which it does not have yet, only builds.

This patch makes it do so.  Once this deploys we can then do the balrog magic. (using any random dep build will not work for these purposes)

Comment 10

[Justin Wood (:Callek)]

Comment on attachment 8490803 [details] [diff] [review]
[configs] v1 - make maple have nightlies

Review of attachment 8490803 [details] [diff] [review]:
-----------------------------------------------------------------

::: mozilla/config.py
@@ +2522,5 @@
> +        # its dep signing server, which may have already been set to the global default.
> +        BRANCHES[branch]['platforms'][platform]['nightly_signing_servers'] = \
> +            branchConfig.get('nightly_signing_servers', branchConfig.get('platforms', {}).get(
> +                             platform, {}).get('nightly_signing_servers',
> +                             BRANCHES[branch]['platforms'][platform]['dep_signing_servers']))

to be clear, I'm not a fan of the formatting here, but its the best I could come up with. I'm open to *any* alternative styling you suggest, just be specific and I'll make it happen

Comment 11

[[e-mail] (:bhearsum)]

Comment on attachment 8490803 [details] [diff] [review]
[configs] v1 - make maple have nightlies

Review of attachment 8490803 [details] [diff] [review]:
-----------------------------------------------------------------

::: mozilla/config.py
@@ +2522,5 @@
> +        # its dep signing server, which may have already been set to the global default.
> +        BRANCHES[branch]['platforms'][platform]['nightly_signing_servers'] = \
> +            branchConfig.get('nightly_signing_servers', branchConfig.get('platforms', {}).get(
> +                             platform, {}).get('nightly_signing_servers',
> +                             BRANCHES[branch]['platforms'][platform]['dep_signing_servers']))

The part that makes it tough for me to read is indentation and line breaks not mapping to any function calls. I suspect pep8ify made it this way. I don't really care that much though.

Comment 12

[Justin Wood (:Callek)]

In production

Comment 13

[[e-mail] (:bhearsum)]

I created the rule to enable these updates. URLs like https://aus4.mozilla.org/update/3/Firefox/15.0a1/20120519040218/WINNT_x86-msvc/en-US/nightly-maple/Windows_NT%206.1.1.0%20%28x64%29/default/default/update.xml?force=1 now receive updates.

Comment 14

[Andrew Overholt [:overholt]]

I just wanted to say that I verified this today (we had some bustage for a while that was preventing clean builds).  Thanks!