Remove useless code in tokenizer

VERIFIED INVALID

Status

()

--
minor
VERIFIED INVALID
17 years ago
4 years ago

People

(Reporter: choess, Assigned: harishd)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

17 years ago
At <URL:http://lxr.mozilla.org/mozilla/htmlparser/src/nsHTMLParser.cpp#554>, we
check for non-ASCII Unicode characters in end tags, supposedly so we don't choke
on XHTML served as text/html. However, at
<URL:http://lxr.mozilla.org/mozilla/htmlparser/src/nsHTMLParser.cpp#582>, we
don't deal with these characters in start tags. Since backwards-compatible XHTML
(text/html) shouldn't have tags with Unicode in them, anyway, that part of the
conditional on line 554 should be removed.

Comment 1

17 years ago
Christopher: err those links are not valid...

Comment 3

17 years ago
Nope, still not valid. I'm getting "This file does not exist."

Comment 5

17 years ago
551 // xml allow non ASCII tag name, consume as end tag. need to make xml view
source work
552 PRBool isXML=(mFlags & NS_IPARSER_FLAG_XML);
553 if(nsCRT::IsAsciiAlpha(theNextChar)||(kGreaterThan==theNextChar)|| 
554 (isXML && (! nsCRT::IsAscii(theNextChar)))) { 


I'm guessing that the XML comment is no longer true. Removing line 551, line 552
and line 554 should do it I would think.


Comment 6

17 years ago
Created attachment 55100 [details] [diff] [review]
patch (not tested)
(Reporter)

Comment 7

17 years ago
Oops, it turns out we need this for XML view source (thanks, Clarence!). Closing
INVALID.
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → INVALID

Comment 8

17 years ago
Verified invalid per Comment #7
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.