106543 - Remove useless code in tokenizer

Status: VERIFIED INVALID

(Core :: DOM: HTML Parser, defect)

Description

[Christopher Hoess (gone)]

At <URL:http://lxr.mozilla.org/mozilla/htmlparser/src/nsHTMLParser.cpp#554>, we
check for non-ASCII Unicode characters in end tags, supposedly so we don't choke
on XHTML served as text/html. However, at
<URL:http://lxr.mozilla.org/mozilla/htmlparser/src/nsHTMLParser.cpp#582>, we
don't deal with these characters in start tags. Since backwards-compatible XHTML
(text/html) shouldn't have tags with Unicode in them, anyway, that part of the
conditional on line 554 should be removed.

Comment 1

[basic]

Christopher: err those links are not valid...

Comment 2

[Christopher Hoess (gone)]

Make that
<URL:http://lxr.mozilla.org/seamonkey/source/htmlparser/src/nsHTMLParser.cpp#554>
and
<URL:http://lxr.mozilla.org/seamonkey/source/htmlparser/src/nsHTMLParser.cpp#582>.

Comment 3

[basic]

Nope, still not valid. I'm getting "This file does not exist."

Comment 4

[Christopher Hoess (gone)]

OK, brain engaged now.
<URL:http://lxr.mozilla.org/seamonkey/source/htmlparser/src/nsHTMLTokenizer.cpp#554>
and
<URL:http://lxr.mozilla.org/seamonkey/source/htmlparser/src/nsHTMLTokenizer.cpp#582>

Sorry! (need sleep...)

Comment 5

[basic]

551 // xml allow non ASCII tag name, consume as end tag. need to make xml view
source work
552 PRBool isXML=(mFlags & NS_IPARSER_FLAG_XML);
553 if(nsCRT::IsAsciiAlpha(theNextChar)||(kGreaterThan==theNextChar)|| 
554 (isXML && (! nsCRT::IsAscii(theNextChar)))) { 


I'm guessing that the XML comment is no longer true. Removing line 551, line 552
and line 554 should do it I would think.

Comment 6

[basic]

Attachment: patch (not tested)

Comment 7

[Christopher Hoess (gone)]

Oops, it turns out we need this for XML view source (thanks, Clarence!). Closing
INVALID.

Comment 8

[Moied]

Verified invalid per Comment #7