1065430 - [Gallery] Visual Refinements preview screenshot

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Eric Pang [:epang] UX]

Attachment: Preview screen

STR:

1. Take a screenshot
2. Press on notification to open the preview

The preview screen currently uses the light skin.  Can we update so it uses the skin of media apps (Dark Grey, white header text and white buttons)?

Also, the status bar should be using the one defined for media apps (dark grey) headers.  I've opened a separate bug (bug 1065419) to update the status bar colour of gallery, will this fix in both places?

Comment 1

[Eric Pang [:epang] UX]

Pavel, is this something you can help with?

Comment 2

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: patch for Gaia/master

Comment 3

[Punam Dahiya [:pdahiya]]

Comment on attachment 8497524 [details] [review]
patch for Gaia/master

Hi Pavel
Attached patch is updating gallery app to not use gaia-header in shared/elements. I am giving r- as we should be able to update preview screen to dark gray headers by adding class="theme-media" to body tag in open.html with shared/elements/gaia-header similar to what is used in apps/gallery/js/index.html. Thanks

Comment 4

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Comment on attachment 8497524 [details] [review]
patch for Gaia/master

I see. PR is updated

Comment 5

[Eric Pang [:epang] UX]

Comment on attachment 8497524 [details] [review]
patch for Gaia/master

Looks good now, thanks Pavel!

Comment 6

[Punam Dahiya [:pdahiya]]

Comment on attachment 8497524 [details] [review]
patch for Gaia/master

Thanks Pavel for the patch, it looks good and has r+

Comment 7

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Thanks :)

Landed to master:
https://github.com/mozilla-b2g/gaia/commit/191d805f4911628d37a8a90a1e23a6013995138f