1065442 - Audit views that use PrivacyPolicyRequiredMixin as it may no longer be required in some situations

Status: VERIFIED FIXED

(Mozilla QA Graveyard :: One and Done, defect, P3)

Description

[Bob Silverberg [:bsilverberg]]

Attachment: Link to Github pull-request: https://github.com/mozilla/oneanddone/pull/175

There is a mixin that forces users to the profile screen in order to sign the privacy policy if they have not already done so. This is set up to fire on a few views, but it is likely no longer needed as users are also forced to sign the privacy policy upon logging in if they haven't already done so. Therefore it would be impossible for a user to access one of these views without already having been forced to sign the privacy policy after logging in. 

This logic was put in place initially to deal with users who hadn't signed the privacy policy but who were still logged in, but I wouldn't think we'd have any of those anymore.

Comment 1

[Bob Silverberg [:bsilverberg]]

Comment on attachment 8487255 [details] [review]
Link to Github pull-request: https://github.com/mozilla/oneanddone/pull/175

Oops, didn't mean to include this. It came over with a clone.

Comment 2

[Tessy]

i would like to work on this issue

Comment 3

[Bob Silverberg [:bsilverberg]]

Thanks Tessy, you are more than welcome to work on this! Could you please assign it to yourself in Bugzilla, so that others do not think it is available to work on?

Comment 4

[Tessy]

assigned: tessy

Comment 5

[Bob Silverberg [:bsilverberg]]

Commit pushed to master at https://github.com/mozilla/oneanddone

https://github.com/mozilla/oneanddone/commit/c2519f889371d8ee30c8def51514687f51387579
Fix Bug 1065442 - Audit views that use PrivacyPolicyRequiredMixin as it may no longer be required in some situations

Comment 6

[Rebecca Billings [:rbillings]]

Verified login on dev as an admin, regular user, and a new user.

Comment 7

[Rebecca Billings [:rbillings]]

Verified on prod