1065477 - Bind FxAccountsProfileClientError to global "this" for B2G

Status: RESOLVED FIXED

(Firefox :: Firefox Accounts, defect)

Description

[Sam Penrose]

This declaration in FxAccountsProfileClient.jsm:

  var FxAccountsProfileClientError = function (details) {

does not export the symbol on B2G.

Comment 1

[Sam Penrose]

Attachment: 1065477-use-this.patch

Fernando this is another nit exposed by running xpcshell-test. Thanks!

Comment 2

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 8487305 [details] [diff] [review]
1065477-use-this.patch

Review of attachment 8487305 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks Sam!

::: services/fxaccounts/FxAccountsProfileClient.jsm
@@ +150,5 @@
>   *   @param {String|null} [details.message]
>   *          Error message
>   * @constructor
>   */
> +this.FxAccountsProfileClientError = function (details) {

nit: no space between "function" and the parenthesis, please.

Comment 3

[Sam Penrose]

Attachment: 1065477-use-this.patch

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/cbf008a9deb1

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/cbf008a9deb1