Bind FxAccountsProfileClientError to global "this" for B2G

RESOLVED FIXED in Firefox 35

Status

()

RESOLVED FIXED
4 years ago
a year ago

People

(Reporter: spenrose, Assigned: spenrose)

Tracking

unspecified
Firefox 35
ARM
Gonk (Firefox OS)
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

4 years ago
This declaration in FxAccountsProfileClient.jsm:

  var FxAccountsProfileClientError = function (details) {

does not export the symbol on B2G.
(Assignee)

Comment 1

4 years ago
Created attachment 8487305 [details] [diff] [review]
1065477-use-this.patch

Fernando this is another nit exposed by running xpcshell-test. Thanks!
Attachment #8487305 - Flags: review?(ferjmoreno)
Comment on attachment 8487305 [details] [diff] [review]
1065477-use-this.patch

Review of attachment 8487305 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks Sam!

::: services/fxaccounts/FxAccountsProfileClient.jsm
@@ +150,5 @@
>   *   @param {String|null} [details.message]
>   *          Error message
>   * @constructor
>   */
> +this.FxAccountsProfileClientError = function (details) {

nit: no space between "function" and the parenthesis, please.
Attachment #8487305 - Flags: review?(ferjmoreno) → review+
(Assignee)

Comment 3

4 years ago
Created attachment 8488305 [details] [diff] [review]
1065477-use-this.patch
Attachment #8487305 - Attachment is obsolete: true
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/cbf008a9deb1
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35

Updated

a year ago
Product: Core → Firefox
Target Milestone: mozilla35 → Firefox 35
You need to log in before you can comment on or make changes to this bug.