1065492 - Some videos thumbnails are rendered with shear

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Sotaro Ikeda [:sotaro]]

+++ This bug was initially created as a clone of Bug #1064126 +++

This bug is created based on Bug 1064126 Comment 8.

video thumbnail of a video of Bug 889238 does not rendered correctly on v2.0 flame. It seems rendered with shear.

Comment 1

[Sotaro Ikeda [:sotaro]]

[Blocking Requested - why for this release]: User can see the video thumbnail's problem.

Comment 2

[Jason Smith [:jsmith]]

QA Wanted for branch checks.

Comment 3

[Sotaro Ikeda [:sotaro]]

I am going to investigate about where causes the problem.

Comment 4

[Sotaro Ikeda [:sotaro]]

Video app's card view's video is already sheared video. ConvertOmxYUVFormatToRGB565() seems to cause the problem.
http://mxr.mozilla.org/mozilla-central/source/gfx/layers/GrallocImages.cpp#265

Comment 5

[Hema Koka [:hema]]

Based on an IRC conversation with Sotaro yesterday, this problem only with videos of sizes in multiples of 8 and therefore is not a normal case. Sotaro is investigating it though. 

Sotaro: Based on your investigation, if the impact of this ends up being huge, please renom with an update based on your findings.

At this point in the 2.0 release only show-stopping issues are taken in (https://wiki.mozilla.org/B2G/Triage#Issues_that_Should_Block). So removing from 2.0 nom.

Comment 6

[Sotaro Ikeda [:sotaro]]

(In reply to Hema Koka [:hema] from comment #5)
> Based on an IRC conversation with Sotaro yesterday, this problem only with
> videos of sizes in multiples of 8 and therefore is not a normal case.

The video's width is multiples of 4.

Comment 7

[Sotaro Ikeda [:sotaro]]

(In reply to Sotaro Ikeda [:sotaro] from comment #6)
> (In reply to Hema Koka [:hema] from comment #5)
> > Based on an IRC conversation with Sotaro yesterday, this problem only with
> > videos of sizes in multiples of 8 and therefore is not a normal case.
> 
> The video's width is multiples of 4.

Sorry, the video's width is multiples of 2.

Comment 8

[Sotaro Ikeda [:sotaro]]

DataSourceSurface's stride is always aligned to 16 Byte. It is not cared when doing color convert by using android::ColorConverter. Stride and width becomes different only when a video width is less than 4.

Comment 9

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Fix a stride when using android::ColorConverter

Comment 10

[Sotaro Ikeda [:sotaro]]

 https://tbpl.mozilla.org/?tree=Try&rev=43205989c12e

Comment 11

[Sotaro Ikeda [:sotaro]]

[Blocking Requested - why for this release]: When the problem happens the user can easily recognize it.
                                             The fix is low risk.

Comment 12

[Sotaro Ikeda [:sotaro]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/40c3d1f0f75c

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/40c3d1f0f75c

Comment 14

[Pi Wei Cheng [:piwei] (inactive)]

Removing qawanted tag due to bug being marked as fixed.

Comment 15

[Rachelle Yang [:ryang][[e-mail]]]

denominate 2.0?