1065507 - Remove js_GetterOnlyPropertyStub

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jason Orendorff [:jorendorff]]

I think the only properties that have JSPROP_GETTER but a JSPropertyOp setter are those that use js_GetterOnlyPropertyStub.

But those properties could just as well have no setter. The only difference in behavior is that non-strict assignment would be a no-op instead of an exception. Sloppy, but it's the standard, and DOM bindings behave that way already.

This will enable further simplifications (see bug 1064551).

Comment 1

[Jason Orendorff [:jorendorff]]

Attachment: , part 1 - Remove dead function xpc_qsGetterOnlyPropertyStub

Comment 2

[Jason Orendorff [:jorendorff]]

Attachment: part 2 - Change XPCWrappedNatives to use a null setter instead of js_GetterOnlyPropertyStub

Comment 3

[Jason Orendorff [:jorendorff]]

Attachment: part 3 - Remove special support for js_GetterOnlyPropertyStub from js/ipc

Comment 4

[Jason Orendorff [:jorendorff]]

Attachment: part 4 - Remove js_GetterOnlyPropertyStub

Comment 5

[Jason Orendorff [:jorendorff]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6b24d1197f43
https://hg.mozilla.org/integration/mozilla-inbound/rev/36cefa560ad5
https://hg.mozilla.org/integration/mozilla-inbound/rev/93d3c7189dd3
https://hg.mozilla.org/integration/mozilla-inbound/rev/b05788abeb29

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6b24d1197f43
https://hg.mozilla.org/mozilla-central/rev/36cefa560ad5
https://hg.mozilla.org/mozilla-central/rev/93d3c7189dd3
https://hg.mozilla.org/mozilla-central/rev/b05788abeb29