Closed Bug 1065574 Opened 5 years ago Closed 5 years ago

Remove UserDataHandler

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla35

People

(Reporter: evilpie, Assigned: evilpie)

Details

Attachments

(1 file)

Attached patch UserDataHandlerSplinter Review
As far as we can tell from mxr.mozilla.org/addons no addon actually passes a handler to setUserData.
Attachment #8487403 - Flags: review?(bugs)
Comment on attachment 8487403 [details] [diff] [review]
UserDataHandler

bz, peterv, does the .webidl change look ok to you?
Attachment #8487403 - Flags: feedback?(peterv)
Attachment #8487403 - Flags: feedback?(bzbarsky)
...it shouldn't be too regression risky based on 
https://mxr.mozilla.org/addons/search?string=setUserData
Comment on attachment 8487403 [details] [diff] [review]
UserDataHandler

The .webidl bit looks great to me.
Attachment #8487403 - Flags: feedback?(bzbarsky) → feedback+
Comment on attachment 8487403 [details] [diff] [review]
UserDataHandler

You need to update uuid of nsIDOMNode and all the interfaces inheriting it.
sfink's tool from https://developer.mozilla.org/en-US/docs/Generating_GUIDs#Perl might be useful for that.
Attachment #8487403 - Flags: review?(bugs) → review+
Or "mach update-uuids".
Oh, a use case for mach! :)
Status: NEW → ASSIGNED
OS: Linux → All
QA Contact: evilpies
Hardware: x86_64 → All
QA Contact: evilpies
Assignee: nobody → evilpies
https://hg.mozilla.org/mozilla-central/rev/9bba47e3ddf4
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Attachment #8487403 - Flags: feedback?(peterv)
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.