If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Remove UserDataHandler

RESOLVED FIXED in mozilla35

Status

()

Core
DOM
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: evilpie, Assigned: evilpie)

Tracking

unspecified
mozilla35
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Created attachment 8487403 [details] [diff] [review]
UserDataHandler

As far as we can tell from mxr.mozilla.org/addons no addon actually passes a handler to setUserData.
Attachment #8487403 - Flags: review?(bugs)

Comment 1

3 years ago
Comment on attachment 8487403 [details] [diff] [review]
UserDataHandler

bz, peterv, does the .webidl change look ok to you?
Attachment #8487403 - Flags: feedback?(peterv)
Attachment #8487403 - Flags: feedback?(bzbarsky)

Comment 2

3 years ago
...it shouldn't be too regression risky based on 
https://mxr.mozilla.org/addons/search?string=setUserData
Comment on attachment 8487403 [details] [diff] [review]
UserDataHandler

The .webidl bit looks great to me.
Attachment #8487403 - Flags: feedback?(bzbarsky) → feedback+

Comment 4

3 years ago
Comment on attachment 8487403 [details] [diff] [review]
UserDataHandler

You need to update uuid of nsIDOMNode and all the interfaces inheriting it.
sfink's tool from https://developer.mozilla.org/en-US/docs/Generating_GUIDs#Perl might be useful for that.
Attachment #8487403 - Flags: review?(bugs) → review+
Or "mach update-uuids".

Comment 6

3 years ago
Oh, a use case for mach! :)
(Assignee)

Updated

3 years ago
Status: NEW → ASSIGNED
OS: Linux → All
QA Contact: evilpies
Hardware: x86_64 → All
(Assignee)

Updated

3 years ago
QA Contact: evilpies
(Assignee)

Updated

3 years ago
Assignee: nobody → evilpies
(Assignee)

Comment 7

3 years ago
I assumed that f+ from bz is enough.
https://tbpl.mozilla.org/?tree=Try&rev=118020b19ddd
https://hg.mozilla.org/integration/mozilla-inbound/rev/9bba47e3ddf4
https://hg.mozilla.org/mozilla-central/rev/9bba47e3ddf4
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Attachment #8487403 - Flags: feedback?(peterv)
You need to log in before you can comment on or make changes to this bug.