Improve Loop xpcshell tests for MozLoopService to have a better chance of detecting coding errors

RESOLVED FIXED in Firefox 34

Status

Hello (Loop)
Client
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

unspecified
mozilla35
Points:
---
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox34 fixed, firefox35 fixed)

Details

(Whiteboard: [loop-uplift])

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Coming out of landing bug 1065052 with bug 1035348 landing just after it, we realised that the tests weren't catching errors which they should be covering.

Hence causing bustage, and resulting in a follow-up:

https://hg.mozilla.org/integration/fx-team/rev/0f8b752951d9

I'll attach a patch for this in a moment.
(Assignee)

Comment 1

3 years ago
Created attachment 8487423 [details] [diff] [review]
Improve Loop xpcshell tests for MozLoopService to have a better chance of detecting coding errors.

This removes the stubbing of hawkRequest that was added in bug 1035348, and uses the xpcshell server instead. Although we have more complexity as we now have to wait for another async action, this does mean we're testing the fall route for the /calls xhr from MozLoopService, hence I think it has better coverage, and is consistent with the rest of the tests.
Attachment #8487423 - Flags: review?(jaws)
Attachment #8487423 - Flags: review?(jaws) → review+
(Assignee)

Comment 2

3 years ago
https://hg.mozilla.org/integration/fx-team/rev/2621e03cb4e4
Target Milestone: --- → mozilla35
https://hg.mozilla.org/mozilla-central/rev/2621e03cb4e4
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Flags: qe-verify-
Whiteboard: [loop-uplift]
Comment on attachment 8487423 [details] [diff] [review]
Improve Loop xpcshell tests for MozLoopService to have a better chance of detecting coding errors.

Approval Request Comment
Uplift request for patches staged and tested on Fig
Attachment #8487423 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/releases/mozilla-aurora/rev/8d53b9d6fc24

Updated

3 years ago
status-firefox34: --- → fixed
status-firefox35: --- → fixed
Comment on attachment 8487423 [details] [diff] [review]
Improve Loop xpcshell tests for MozLoopService to have a better chance of detecting coding errors.

I worked with Randell and Maire on uplifting a large number of Loop bugs at once. All of the bugs have been staged on Fig and tested by QE before uplift to Aurora. As well, all of the bugs are isolated to the Loop client. Randell handled the uplift with my approval. I am adding approval to the bug after the fact for bookkeeping.
Attachment #8487423 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.