Don't report ConflictError as a 503 on POST requests

VERIFIED FIXED

Status

VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: rfkelly, Assigned: rfkelly)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa+])

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
As noted in Bug 1062120, failing POST requests are currently reported as a "200 OK" with failure codes in the response body.  The exception is ConflictError, which after Bug 1051739 is now reported straight through to the client as a 503.

We think this is showing up in prod as increased reports of "server maintenance" errors for otherwise transient write conflicts.  This patch changes the way ConflictError is reported to match how other BackendError instances are handled on POST requests.

It is not pretty, but the existing "turn a 409 into a 503" handling was not pretty either...
(Assignee)

Comment 1

4 years ago
Created attachment 8487582 [details] [diff] [review]
sync-conflicterror-is-a-o-k.diff
Assignee: nobody → rfkelly
Attachment #8487582 - Flags: review?(telliott)
Status: NEW → ASSIGNED
QA Contact: jbonacci
Whiteboard: [qa+]
(Assignee)

Comment 2

4 years ago
For full context: Bug 1034377 also landed recently, which makes more things show up as ConflictError that would otherwise have been a generic BackendError.  As a follow-up we should revisit that and see if it's over-reporting things that are not really semantically a ConflictError.
Attachment #8487582 - Flags: review?(telliott) → review+
(Assignee)

Comment 3

4 years ago
https://github.com/mozilla-services/server-syncstorage/commit/150bdd2819591476b2ae7b64db015cbdcb988e97
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
(Assignee)

Updated

4 years ago
Blocks: 1065768
1.5.10 is out in Production.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.