Closed Bug 1065753 Opened 10 years ago Closed 10 years ago

Remove sb-icon-notification from statusbar.css

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::System
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(tracking-b2g:backlog, b2g-v2.0 wontfix, b2g-v2.0M wontfix, b2g-v2.1 wontfix, b2g-v2.2 fixed)

Status:
RESOLVED FIXED
Project Flags:
tracking-b2g backlog
Tracking Flags:
Tracking Status
b2g-v2.0 --- wontfix
b2g-v2.0M --- wontfix
b2g-v2.1 --- wontfix
b2g-v2.2 --- fixed

People

(Reporter: mikehenrty, Assigned: gauravmittal1995, Mentored)

Details

(Whiteboard: [systemsfe][good first bug])

Attachments

(1 file)

PR for Bug
46 bytes, text/x-github-pull-request
mikehenrty
: review+
Details | Review 
Now that bug 1042713 has landed, and we've killed the old notification icon, we can remove all traces of `sb-icon-notification` from our statusbar.css.
I've just finished looking over statusbar.css and am cloning it to my desktop right now. I can remove all instances of 'sb-icon-notification' from statusbar.css real quick and then do a pull request on Github.
That sounds great! Let me know if you need any help with that :)
Thanks!
Whiteboard: [systemfe][good first bug] → [systemsfe][good first bug]
blocking-b2g: --- → backlog
Hi! How is it going with this bug? Do you need any help?
I can take it, if you want.

Thanks!
Flags: needinfo?(nmorgan1214)
You can take it if you want, I'm buried in exam week right now.
Flags: needinfo?(nmorgan1214)
Ok! Don't hesitate to contact me if you want to help on any other bug! Thanks!
Hello ... is this bug free to take? ... if it is, i would like to work on it
Attached file PR for Bug — 

        Attachment #8494007 -
        Flags: review?(mhenretty)

        Attachment #8494007 -
        Flags: review?(apastor)

    
    

    
  
Comment on attachment 8494007 [details] [review]
PR for Bug

Looking good! Thanks for doing this :)

        Attachment #8494007 -
        Flags: review?(mhenretty)

        Attachment #8494007 -
        Flags: review?(apastor)

        Attachment #8494007 -
        Flags: review+

    
    

    
  
We are having issues with our automated test framework ATM. I will land this as soon as we get it figured out.

    
    

    
  
Thanks again, gauravmittal!

master: https://github.com/mozilla-b2g/gaia/commit/83d7245c49ef6c966e7954db8f650f5f5c8432a6
Status: NEW → RESOLVED
Closed: 10 years ago

          status-b2g-v2.0:
          --- → wontfix

          status-b2g-v2.0M:
          --- → wontfix

          status-b2g-v2.1:
          --- → wontfix

          status-b2g-v2.2:
          --- → fixed
Resolution: --- → FIXED
Assignee: nobody → gauravmittal1995
blocking-b2g: backlog → ---

          tracking-b2g:
          --- → backlog

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: