Closed Bug 1065774 Opened 10 years ago Closed 10 years ago

Be more precise in PromiseFlatString docs about why assigning PromiseFlatString(...) to a reference is safe

Categories

(Core :: XPCOM, defect)

Product:
Core
Component:
XPCOM
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla35

People

(Reporter: Waldo, Assigned: Waldo)

Details

Attachments

(1 file)

Patch
1.63 KB, patch
froydnj
: review+
Details | Diff | Splinter Review 
I didn't know assigning a tepmorary to a referenc, extended the temporary's lifetime to that of the reference.  It would be nice if the in-file comment were more precise about why this is happening, citing chapter/verse for authority.
Attached patch Patch — — Splinter Review 

        Attachment #8487611 -
        Flags: review?(nfroyd)

        Attachment #8487611 -
        Flags: review?(nfroyd) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/5c03643c3180
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Flags: qe-verify-

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: