Remove long-busted Solaris stack-walking code

RESOLVED FIXED in mozilla35

Status

()

Core
XPCOM
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: njn, Assigned: njn)

Tracking

unspecified
mozilla35
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
There's some Solaris-specific unwind code in nsStackWalk.cpp that should be
removed. Why?

BenWa added an extra argument to NS_WalkStackCallback in bug 766579, which
landed in July 2012. He updated the Solaris code but missed a couple of places,
and so the code hasn't compiled since then. And nobody has complained.

Here are the details of the missed places.

First, we have this function:

> static void   cs_operate ( void (*operate_func)(void *, void *, void *),
>                            void * usrarg );

and the only callsite is this:

> cs_operate(load_address, &args);

and load_address's signature is this:

> static int    load_address ( void * pc, void * arg );

which has the wrong number of arguments.

Second, within load_address there is a call like this:

> (args->callback)(pc, args->closure);

where |args| is a my_user_args and so |args->closure| is a
NS_WalkStackCallback, which requires three args.
(Assignee)

Comment 1

3 years ago
Created attachment 8487656 [details] [diff] [review]
Remove long-busted Solaris stack-walking code

 1 file changed, 2 insertions(+), 263 deletions(-)
Attachment #8487656 - Flags: review?(nfroyd)
Comment on attachment 8487656 [details] [diff] [review]
Remove long-busted Solaris stack-walking code

Review of attachment 8487656 [details] [diff] [review]:
-----------------------------------------------------------------

Bustage?  In a platform/configuration not in continuous integration?  Shocked, shocked I say!
Attachment #8487656 - Flags: review?(nfroyd) → review+
(Assignee)

Comment 3

3 years ago
Try looks good: https://tbpl.mozilla.org/?tree=Try&rev=45439e9c3114
(Assignee)

Comment 4

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/a3989e17310c
https://hg.mozilla.org/mozilla-central/rev/a3989e17310c
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in before you can comment on or make changes to this bug.