Closed
Bug 1065850
Opened 12 years ago
Closed 12 years ago
MP4 demuxer blocks waiting for the first moof box
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla35
People
(Reporter: ajones, Assigned: ajones)
References
Details
Attachments
(1 file)
|
10.60 KB,
patch
|
rillian
:
review+
|
Details | Diff | Splinter Review |
The MP4 demuxer reads up to the first moof box before it completes reading the metadata. This contributes to bug 1065827 for MSE.
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #8487681 -
Flags: review?(giles)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 8487681 [details] [diff] [review]
Read as little as possible to get the MP4 track metadata
Review of attachment 8487681 [details] [diff] [review]:
-----------------------------------------------------------------
::: media/libstagefright/frameworks/av/media/libstagefright/MPEG4Extractor.cpp
@@ +441,5 @@
> && !track->includes_expensive_metadata) {
> track->includes_expensive_metadata = true;
>
> const char *mime;
> CHECK(track->meta->findCString(kKeyMIMEType, &mime));
Do you want to remove the mime lookup too?
Attachment #8487681 -
Flags: review?(giles) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
|
|
Assignee | |
Comment 4•12 years ago
|
||
|
|
||
Comment 5•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in
before you can comment on or make changes to this bug.
Description
•