MP4 demuxer blocks waiting for the first moof box

RESOLVED FIXED in mozilla35

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: kentuckyfriedtakahe, Assigned: kentuckyfriedtakahe)

Tracking

Trunk
mozilla35
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

The MP4 demuxer reads up to the first moof box before it completes reading the metadata. This contributes to bug 1065827 for MSE.
Created attachment 8487681 [details] [diff] [review]
Read as little as possible to get the MP4 track metadata
Attachment #8487681 - Flags: review?(giles)
Comment on attachment 8487681 [details] [diff] [review]
Read as little as possible to get the MP4 track metadata

Review of attachment 8487681 [details] [diff] [review]:
-----------------------------------------------------------------

::: media/libstagefright/frameworks/av/media/libstagefright/MPEG4Extractor.cpp
@@ +441,5 @@
>              && !track->includes_expensive_metadata) {
>          track->includes_expensive_metadata = true;
>  
>          const char *mime;
>          CHECK(track->meta->findCString(kKeyMIMEType, &mime));

Do you want to remove the mime lookup too?
Attachment #8487681 - Flags: review?(giles) → review+
https://hg.mozilla.org/mozilla-central/rev/5876e536d628
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in before you can comment on or make changes to this bug.