1065850 - MP4 demuxer blocks waiting for the first moof box

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

The MP4 demuxer reads up to the first moof box before it completes reading the metadata. This contributes to bug 1065827 for MSE.

Comment 1

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Attachment: Read as little as possible to get the MP4 track metadata

Comment 2

[Ralph Giles (:rillian)]

Comment on attachment 8487681 [details] [diff] [review]
Read as little as possible to get the MP4 track metadata

Review of attachment 8487681 [details] [diff] [review]:
-----------------------------------------------------------------

::: media/libstagefright/frameworks/av/media/libstagefright/MPEG4Extractor.cpp
@@ +441,5 @@
>              && !track->includes_expensive_metadata) {
>          track->includes_expensive_metadata = true;
>  
>          const char *mime;
>          CHECK(track->meta->findCString(kKeyMIMEType, &mime));

Do you want to remove the mime lookup too?

Comment 3

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

https://tbpl.mozilla.org/?tree=Try&rev=f4da6657d043

Comment 4

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5876e536d628

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5876e536d628