1065856 - Support pulse config in pulsebuildmonitor

Status: RESOLVED FIXED

(Webtools :: Pulse, defect)

Description

[Mark Côté [:mcote]]

We're going to need pulsebuildmonitor to support custom PulseConfigurations in order to use PulseGuardian.

Comment 1

[Mark Côté [:mcote]]

Attachment: Support custom PulseConfigurations

Comment 2

[Jonathan Griffin (:jgriffin)]

Comment on attachment 8487678 [details] [diff] [review]
Support custom PulseConfigurations

Review of attachment 8487678 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm!

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Marc, what does that mean to customers of pulsebuildmonitor? Do they have to change their code in terms of this new feature?

Comment 4

[Mark Côté [:mcote]]

A little, yes.  As per my posts to tools.pulse and the "Security Model" section on the Pulse wiki page, all Pulse consumers, including those using pulsebuildmonitor, will have to register with PulseGuardian, which will create individual users on Pulse itself.  You'll have to configure your pulsebuildmonitor client app to use the Pulse username and password that you entered when creating the user on PulseGuardian (I've updated the README appropriately).  The 'public' user will be deleted at some point after we switch everything over to using new exchanges.

You'll also have to upgrade mozillapulse at that time, since exchange names will also be changing.  I'll be sending out emails to known Pulse users soon with more details, including when we plan to do the switchover.

Comment 5

[Mark Côté [:mcote]]

To be clear, nothing needs to be done because of this feature specifically; rather, all Pulse users will have to be updated when we switch over to the new security model in a week or two.

http://hg.mozilla.org/automation/pulsebuildmonitor/rev/da52cf8809d6

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 8487678 [details] [diff] [review]
Support custom PulseConfigurations

Review of attachment 8487678 [details] [diff] [review]:
-----------------------------------------------------------------

::: pulsebuildmonitor/pulsebuildmonitor.py
@@ +27,5 @@
>      def __init__(self, label=None, trees='mozilla-central',
>                   durable=False, platforms=None, tests=None,
>                   buildtypes=None, products=None, buildtags=None,
>                   logger=None, talos=False, builds=False,
> +                 unittests=False, locales=None, pulse_cfg=None):

Not sure if I misunderstood the changes, but if we now have to always use a username, shouldn't this be a mandatory option?

Comment 7

[Mark Côté [:mcote]]

Yeah, you are probably right.  I just defaulted to None because all the parameters are optional atm, but that doesn't really make sense since I plan on having mozillapulse throw an error if the user or password isn't set.  I'll file a bug to do all that at once.