Add interpolation for schema v2 url params (eg openURL)

RESOLVED FIXED

Status

Release Engineering
Balrog: Backend
P2
normal
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: nthomas, Assigned: nthomas)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
We support replacing %LOCALE% with the locale in the query for detailsURL and licenseURL, but should add support for v2 params such as openURL, billboardURL, notificationURL, alertURL.

Blocks balrog beta because we need to use openURL for the betas from 10 to 28 inclusive.
(Assignee)

Comment 1

3 years ago
Created attachment 8488287 [details] [diff] [review]
[balrog] Interpolate interpolate interpolate!      (interpolate!!!)
Attachment #8488287 - Flags: review?(bhearsum)
Comment on attachment 8488287 [details] [diff] [review]
[balrog] Interpolate interpolate interpolate!      (interpolate!!!)

Review of attachment 8488287 [details] [diff] [review]:
-----------------------------------------------------------------

bork bork bork!
Attachment #8488287 - Flags: review?(bhearsum) → review+

Comment 3

3 years ago
Commit pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/edc5a38841e4a600da7979b9a1df7a7bf38a0c1f
Bug 1065857, interpolate %LOCALE% in v2+ schema URL properties, r=bhearsum
(Assignee)

Updated

3 years ago
Depends on: 1067624
(Assignee)

Comment 4

3 years ago
In production today.
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.