1065866 - [Camera][Gecko] Abort StartRecording while previous call is in progress

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[shinuk]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/37.0.2062.103 Safari/537.36

Steps to reproduce:

double touching recording start button.


Actual results:

recording error occurred with the message below and camera(preview) stopped.

DOM OnUserError aContext=6, error='GeneralFailure'



Expected results:

aborting another StartRecording call while previous StartRecording is in progress.

Comment 1

[shinuk]

Attachment: abort_another_startrecording_call

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): camera video recording
User impact if declined: camera test fail
Testing completed: not reproducible
Risk to taking this patch (and alternatives if risky): no
String or UUID changes made by this patch:

Comment 2

[Mike Habicher [:mikeh] (high bugzilla latency)]

Shinuk, this looks fine to me. I'll give it an r+ once you configure your hg client to produce landable patches:

https://developer.mozilla.org/en-US/docs/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F

Comment 3

[bhavana bajaj [:bajaj]]

Is this a recent camera regression on 2.0 ? If not this is too late to fix in 2.0 and will have to be land on 2.1 branch and get fixed in 2.1

Comment 4

[shinuk]

Attachment: aborting_another_startrecording_call

Comment 5

[Mike Habicher [:mikeh] (high bugzilla latency)]

Comment on attachment 8488447 [details] [diff] [review]
aborting_another_startrecording_call

Review of attachment 8488447 [details] [diff] [review]:
-----------------------------------------------------------------

r+ without a test due to emulator limitations.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/7c8b3cd5e57e

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/7c8b3cd5e57e