Bug 1065885 (no-jschar)

Remove jschar from mail and mailnews

RESOLVED FIXED in Thunderbird 35.0

Status

Thunderbird
General
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: rkent, Assigned: Magnus Melin)

Tracking

Trunk
Thunderbird 35.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
jschar is used in mailTestUtils.js and aboutSupportWin32.js

From m.d.platform 2014-08-14 "JSAPI PSA: RIP jschar. Hello char16_t.":

Since Firefox 27 (bug 8950470), SpiderMonkey's jschar has been a typedef for char16_t, a new C++11 type distinct from uint16_t.

With bug 1063962, SpiderMonkey's jschar typedef is gone. SpiderMonkey, its JSAPI, and Gecko now use char16_t directly.

C++ code (outside mozilla-central) compiling against mozilla-central's JSAPI will need to replace `jschar` with `char16_t` in their code. Because jschar was just a typedef for char16_t, code using char16_t should still be API and ABI compatible with the JSAPI of SpiderMonkey's current stable release (31). The next SpiderMonkey release will be 38.

This change also affects js-ctypes and the Add-on SDK. JS code (outside mozilla-central) using `ctypes.jschar` will need to be replaced with `ctypes.char16_t`. If this is too much of a compatibility problem for add-ons, we could keep ctypes.jschar as an alias for ctypes.char16_t.


chris
(Reporter)

Updated

4 years ago
Alias: no-jschar
Blocks: 1054354
(Assignee)

Updated

4 years ago
Assignee: nobody → mkmelin+mozilla
(Assignee)

Comment 1

4 years ago
Created attachment 8488000 [details] [diff] [review]
bug1065885_jschar.patch

Try looks ok - https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=18e5ef76b02a
Attachment #8488000 - Flags: review?(kent)
(Assignee)

Updated

4 years ago
Status: NEW → ASSIGNED
(Reporter)

Comment 2

4 years ago
Comment on attachment 8488000 [details] [diff] [review]
bug1065885_jschar.patch

Review of attachment 8488000 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Thanks!

We still need the mailnews part.
Attachment #8488000 - Flags: review?(kent) → review+
(Assignee)

Comment 3

4 years ago
(In reply to Kent James (:rkent) from comment #2)
> We still need the mailnews part.

This already included the mailnews part. What part did you have in mind?
(Assignee)

Comment 4

4 years ago
https://hg.mozilla.org/comm-central/rev/c4935789ba20 -> FIXED
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
OS: Windows 8.1 → All
Hardware: x86_64 → All
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 35.0
(Reporter)

Comment 5

4 years ago
(In reply to Magnus Melin from comment #3)
> (In reply to Kent James (:rkent) from comment #2)
> > We still need the mailnews part.
> 
> This already included the mailnews part. What part did you have in mind?

Yes you are correct, sorry.
(Reporter)

Updated

4 years ago
No longer blocks: 1054354
You need to log in before you can comment on or make changes to this bug.