Closed
Bug 1065897
Opened 10 years ago
Closed 10 years ago
[Bluetooth] Port bug Bug 1061489 to bluetooth2
Categories
(Firefox OS Graveyard :: Bluetooth, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: tzimmermann, Assigned: tzimmermann)
References
Details
Attachments
(4 files, 3 obsolete files)
12.36 KB,
patch
|
Details | Diff | Splinter Review | |
242.60 KB,
patch
|
tzimmermann
:
review+
|
Details | Diff | Splinter Review |
146.87 KB,
patch
|
tzimmermann
:
review+
|
Details | Diff | Splinter Review |
669 bytes,
patch
|
tzimmermann
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8488550 -
Flags: review?(btian)
Assignee | ||
Comment 2•10 years ago
|
||
Attachment #8488551 -
Flags: review?(btian)
Assignee | ||
Comment 3•10 years ago
|
||
Attachment #8488552 -
Flags: review?(btian)
Assignee | ||
Comment 4•10 years ago
|
||
FYI, this is the diff between 'bluetooth/' and 'bluetooth2/'. I added the changes of 'bluetooth2/' to the ported patches; except for a few build and version fixes. 'bluetooth/' has way better testing for different compilers and ANDROID_VERSIONs, so it makes sense to keep this code.
Comment 5•10 years ago
|
||
Comment on attachment 8488550 [details] [diff] [review] [01] Bug 1065897: Move Bluedroid code out of BluetoothInterface.{cpp,h} (under bluetooth2/) Review of attachment 8488550 [details] [diff] [review]: ----------------------------------------------------------------- LGTM.
Attachment #8488550 -
Flags: review?(btian) → review+
Comment 6•10 years ago
|
||
Comment on attachment 8488552 [details] [diff] [review] [03] Bug 1065897: Updating CLOBBER Review of attachment 8488552 [details] [diff] [review]: ----------------------------------------------------------------- LGTM
Attachment #8488552 -
Flags: review?(btian) → review+
Comment 7•10 years ago
|
||
Comment on attachment 8488551 [details] [diff] [review] [02] Bug 1065897: Distribute Bluetooth HAL implementation among multiple files (unter bluetooth2/) Review of attachment 8488551 [details] [diff] [review]: ----------------------------------------------------------------- r=me with comments addressed. ::: dom/bluetooth2/bluedroid/BluetoothHALHelpers.h @@ +18,5 @@ > +#include "mozilla/ArrayUtils.h" > +#include "mozilla/dom/bluetooth/BluetoothTypes.h" > +#include "nsThreadUtils.h" > + > +#if MOZ_IS_GCC && MOZ_GCC_VERSION_AT_LEAST(4, 7, 0) Please rebase on bug 1061481 patch 3/3 changes: http://hg.mozilla.org/mozilla-central/rev/abc3a737f800 1) moves macro |CONVERT| definition to BluetoothCommon.h 2) revise function |Convert(bt_device_type_t aIn, BluetoothDeviceType& aOut)| 3) replace |mDeviceType| with |mTypeOfDevice| in function |Convert(const bt_property_t& aIn, BluetoothProperty& aOut)|. @@ +80,5 @@ > + aOut = sScanMode[aIn]; > + return NS_OK; > +} > + > + nit: remove extra newline. @@ +769,5 @@ > + * instance of this structure as the first argument to |Convert| > + * to convert an array. The output type has to support the array > + * subscript operator. > + */ > +template <typename T> nit: Please unify the inconsistency between "template <" and "template<" in this file. @@ +1301,5 @@ > + { > + MOZ_ASSERT(mMethod); > + } > + > + template<typename T1,typename T2, typename T3, typename T4> nit: add space before |typename T2|. ::: dom/bluetooth2/bluedroid/BluetoothSocketHALInterface.cpp @@ +7,5 @@ > +#include "BluetoothSocketHALInterface.h" > +#include <errno.h> > +#include <sys/socket.h> > +#include <unistd.h> > +#include "BluetoothHALHelpers.h" nit: move this including to right after |#include "BluetoothSocketHALInterface.h"|. @@ +14,5 @@ > +BEGIN_BLUETOOTH_NAMESPACE > + > +typedef > + BluetoothHALInterfaceRunnable1<BluetoothSocketResultHandler, void, > + int, int> nit: fix the indention and all the following. @@ +77,5 @@ > +} > + > +void > +BluetoothSocketHALInterface::Listen(BluetoothSocketType aType, > + const nsAString& aServiceName, nit: fix the indention. @@ +393,5 @@ > +}; > + > +void > +BluetoothSocketHALInterface::Connect(const nsAString& aBdAddr, > + BluetoothSocketType aType, Ditto. @@ +459,5 @@ > +}; > + > +void > +BluetoothSocketHALInterface::Accept(int aFd, > + BluetoothSocketResultHandler* aRes) Ditto.
Attachment #8488551 -
Flags: review?(btian) → review+
Assignee | ||
Comment 8•10 years ago
|
||
Hi Ben, thanks for the review. No problem, except for > ::: dom/bluetooth2/bluedroid/BluetoothSocketHALInterface.cpp > @@ +7,5 @@ > > +#include "BluetoothSocketHALInterface.h" > > +#include <errno.h> > > +#include <sys/socket.h> > > +#include <unistd.h> > > +#include "BluetoothHALHelpers.h" > > nit: move this including to right after |#include > "BluetoothSocketHALInterface.h"|. I think this violates the style guile, as listed in https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style#C.2FC.2B.2B_practices
Assignee | ||
Comment 9•10 years ago
|
||
Changes since v1: - integrated changes from bug 1061481 - cleaned up template declarations - cleaned up indention - cleaned up new lines
Attachment #8488551 -
Attachment is obsolete: true
Attachment #8493083 -
Flags: review+
Assignee | ||
Comment 10•10 years ago
|
||
Changes since v1: - rebased only
Attachment #8488550 -
Attachment is obsolete: true
Attachment #8493100 -
Flags: review+
Assignee | ||
Comment 11•10 years ago
|
||
Changes since v1: - rebased only
Attachment #8488552 -
Attachment is obsolete: true
Attachment #8493101 -
Flags: review+
Assignee | ||
Comment 12•10 years ago
|
||
Ben, I'm seeing massive problems with my Internet connection today. Could you land these patches for me? Thanks a lot.
Flags: needinfo?(btian)
Comment 13•10 years ago
|
||
Landed on b2g-inbound. https://hg.mozilla.org/integration/b2g-inbound/rev/365cd34d303d https://hg.mozilla.org/integration/b2g-inbound/rev/3c8dfe1b5616 https://hg.mozilla.org/integration/b2g-inbound/rev/7fd6e16da5c8
Flags: needinfo?(btian)
Comment 14•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/365cd34d303d https://hg.mozilla.org/mozilla-central/rev/3c8dfe1b5616 https://hg.mozilla.org/mozilla-central/rev/7fd6e16da5c8
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•