1065987 - [Tab View] Visual Refinements for tab view

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[Eric Pang [:epang] UX]

Attachment: visual refinments.jpg

Hi Etienne!

Can you help with some visual refinements to the tab manager?

I did a review and there are some small changes needed, but it's looking much better then before already!

I've attached an image with the changes that are needed.

The spec can be found here (second image):
https://mozilla.box.com/s/iouyivjtc78t1lhrnbi7

Thanks again for the great work! :)

Comment 1

[Kevin Grandon :kgrandon]

Wrong blocking bug.

Comment 2

[Eric Pang [:epang] UX]

Attachment: Landscape.png

Hey Etienne, just wanted to add a note on the landscape view.  Same issues are seen, but one extra, the card should show the state that the screenshot was taken.  Currently the if the screen is taken in portrait it's stretched to fill the space.  It should just appear on it's side, if it's taken in landscape it would fill the space correctly.

Task manager spec shows it better in case what I said didn't make any sense :).
https://mozilla.box.com/s/3enhx3klfnhqt24ptyrm

Let me know if you have any questions, thanks!

Comment 3

[Etienne Segonzac (:etienne)]

(In reply to Eric Pang [:epang] from comment #2)
> Created attachment 8488535 [details]
> Landscape.png
> 
> Hey Etienne, just wanted to add a note on the landscape view.  Same issues
> are seen, but one extra, the card should show the state that the screenshot
> was taken.  Currently the if the screen is taken in portrait it's stretched
> to fill the space.  It should just appear on it's side, if it's taken in
> landscape it would fill the space correctly.
> 
> Task manager spec shows it better in case what I said didn't make any sense
> :).
> https://mozilla.box.com/s/3enhx3klfnhqt24ptyrm
> 
> Let me know if you have any questions, thanks!

Oh we should definitely file a separate bug for this because it'll be a a new feature blocked by bug 1054949.

Comment 4

[Etienne Segonzac (:etienne)]

Attachment: Gaia PR

Comment 5

[Etienne Segonzac (:etienne)]

Attachment: tweaked-filtered-cardview.png

Comment 6

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 8488738 [details] [review]
Gaia PR

Bonus marks for removing more code than you added :) 
We should wait for Eric's approval to land though.

Comment 7

[Eric Pang [:epang] UX]

(In reply to Etienne Segonzac (:etienne) from comment #3)
> (In reply to Eric Pang [:epang] from comment #2)
> > Created attachment 8488535 [details]
> > Landscape.png
> > 
> > Hey Etienne, just wanted to add a note on the landscape view.  Same issues
> > are seen, but one extra, the card should show the state that the screenshot
> > was taken.  Currently the if the screen is taken in portrait it's stretched
> > to fill the space.  It should just appear on it's side, if it's taken in
> > landscape it would fill the space correctly.
> > 
> > Task manager spec shows it better in case what I said didn't make any sense
> > :).
> > https://mozilla.box.com/s/3enhx3klfnhqt24ptyrm
> > 
> > Let me know if you have any questions, thanks!
> 
> Oh we should definitely file a separate bug for this because it'll be a a
> new feature blocked by bug 1054949.

ok, no problem!  Opened a follow up bug here: https://bugzilla.mozilla.org/show_bug.cgi?id=1067309

Comment 8

[Eric Pang [:epang] UX]

Comment on attachment 8488739 [details]
tweaked-filtered-cardview.png

Looks good!  Thanks for working on this Etienne :)

Comment 9

[Sam Foster [:sfoster] (he/him)]

Patch has ui-review+ and r+, and a green Gaia-Try run (barring unrelated oop mochitests)
Merged to master: https://github.com/mozilla-b2g/gaia/commit/1ba4ba1f094e86bfbfae4bd65bec0966f42e38d4

Comment 10

[Rachel Pribble [:rpribble]]

Verified fixed in the Flame v2.2. 
The graphics issues listed in the attachments are no longer occuring (stroke appears to have been removed, header is changed to grey instead of black, no gap is seen at the bottom of a card in card viewer).

Device: Flame 2.2 Master (319 MB) 
BuildID: 20140916040203
Gaia: e2d70bee03b5380ac327a145e5d694fb2443f018
Gecko: 3b7921328fc1
Version: 35.0a1 (2.2 Master)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0