Closed Bug 1065994 Opened 5 years ago Closed 5 years ago

[mozrunner] Unit tests for a real binary are failing a lot

Categories

(Testing :: Mozbase, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla35

People

(Reporter: whimboo, Assigned: ahal)

References

(Blocks 1 open bug)

Details

(Keywords: regression)

Attachments

(1 file)

This is a regression and maybe related to the large refactoring Andrew did for mozrunner a while ago. I will do a regression test in a bit.

The tests are all failing with the same traceback:

Traceback (most recent call last):
  File "/mozilla/code/firefox/inbound/testing/mozbase/mozrunner/tests/mozrunnertest.py", line 21, in setUp
    self.runner = mozrunner.FirefoxRunner(self.profile)
  File "/mozilla/code/firefox/inbound/testing/mozbase/mozrunner/mozrunner/runners.py", line 47, in FirefoxRunner
    return GeckoRuntimeRunner(*args, **kwargs)
  File "/mozilla/code/firefox/inbound/testing/mozbase/mozrunner/mozrunner/base/browser.py", line 31, in __init__
    if sys.platform == 'linux2' and self.binary.endswith('-bin'):
AttributeError: 'FirefoxProfile' object has no attribute 'endswith'

Those failures will actually block us from getting those real binary tests enabled on TBPL.
It's indeed a regression from the refactoring from Andrew as done on bug 997244. Andrew, can you get this fixed?
Blocks: 997244
I'll look into it.
Assignee: nobody → ahalberstadt
Status: NEW → ASSIGNED
This got them all passing on my system.
Attachment #8487882 - Flags: review?(hskupin)
Blocks: 966441
Comment on attachment 8487882 [details] [diff] [review]
fix_mozrunner_tests

Review of attachment 8487882 [details] [diff] [review]:
-----------------------------------------------------------------

Works fine for me! Thanks for the quick fix.
Attachment #8487882 - Flags: review?(hskupin) → review+
https://hg.mozilla.org/mozilla-central/rev/e7695039b761
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in before you can comment on or make changes to this bug.