1065994 - [mozrunner] Unit tests for a real binary are failing a lot

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

This is a regression and maybe related to the large refactoring Andrew did for mozrunner a while ago. I will do a regression test in a bit.

The tests are all failing with the same traceback:

Traceback (most recent call last):
  File "/mozilla/code/firefox/inbound/testing/mozbase/mozrunner/tests/mozrunnertest.py", line 21, in setUp
    self.runner = mozrunner.FirefoxRunner(self.profile)
  File "/mozilla/code/firefox/inbound/testing/mozbase/mozrunner/mozrunner/runners.py", line 47, in FirefoxRunner
    return GeckoRuntimeRunner(*args, **kwargs)
  File "/mozilla/code/firefox/inbound/testing/mozbase/mozrunner/mozrunner/base/browser.py", line 31, in __init__
    if sys.platform == 'linux2' and self.binary.endswith('-bin'):
AttributeError: 'FirefoxProfile' object has no attribute 'endswith'

Those failures will actually block us from getting those real binary tests enabled on TBPL.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

It's indeed a regression from the refactoring from Andrew as done on bug 997244. Andrew, can you get this fixed?

Comment 2

[Andrew Halberstadt [:ahal]]

I'll look into it.

Comment 3

[Andrew Halberstadt [:ahal]]

Attachment: fix_mozrunner_tests

This got them all passing on my system.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 8487882 [details] [diff] [review]
fix_mozrunner_tests

Review of attachment 8487882 [details] [diff] [review]:
-----------------------------------------------------------------

Works fine for me! Thanks for the quick fix.

Comment 5

[Andrew Halberstadt [:ahal]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e7695039b761

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e7695039b761