Open Bug 106610 Opened 18 years ago Updated 5 years ago

Separate input boxes for each view


(Other Applications :: ChatZilla, enhancement)

Not set


(Not tracked)


(Reporter: jwatt, Assigned: rginda)




(1 file)

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Win 9x 4.90; en-US; rv:0.9.5) Gecko/20011011
BuildID:    2001101117

As chatzilla stands one input box is used for all views that may be open for
different channels. Hence if text is typed into the input box and the user
switches to another view without hitting Enter, the text they entered is in the
input box for the new view. Since you never enter text for one view in the input
box of another it would seem to me to make more sence to have separate input
boxes for each view. This saves problems with text being entered in one view
then inadvertently sent to the wrong channel if the user changes view and sends
of some text to the new view without looking at the input box. It may sound
unlikely, but I almost did it, and it was a pain to have to delete the text I
had typed out but didn't want to post until the person it was directed to had
returned after temporarily leaving. 

Reproducible: Didn't try
id like a whole seperate window for each channel, rather than a tabbed view.  
which would also solve this problem.  
Perhaps i should post a whole new bug? with this one as a dependency?? i dunno
Alan, see bug 76175.
Remove myself from QA of 33 open Chatzilla bugs and change to default QA
contact, since I have no way to verify these easily.  Still no working Mozilla
on my primary platform and it doesn't look like it will happen anytime soon. :(
QA Contact: mozilla → samuel
*** Bug 195225 has been marked as a duplicate of this bug. ***
Attached patch patch v1Splinter Review
Added an input history buffer for each view.
Attachment #117678 - Flags: review?(rginda)
Comment on attachment 117678 [details] [diff] [review]
patch v1

>--- chatzilla.orig/content/chatzilla/lib/js/irc.js	2003-02-26 09:57:38.000000000 +0900
>+++ chatzilla/content/chatzilla/lib/js/irc.js	2003-03-18 22:16:35.000000000 +0900
>@@ -90,6 +90,8 @@
>     this.serverList = serverList;
>     this.eventPump = eventPump;
>     this.servers = new Object();
>+    this.inputHistory = new Array();
>+    this.lastHistoryReferenced = -1;

This is crossing the line a bit.  irc.js is supposed to be the irc library, and
not know anything about the UI.

Personally, I think I prefer thte current behavior, so I'd like to see a pref
for this.  How about leaving client.inputHistory and
client.lastHistoryReferenced where they are, but save/restore them to the
currentObject when the tab changes.  Only if the pref is set.
Attachment #117678 - Flags: review?(rginda) → review-
*** Bug 231857 has been marked as a duplicate of this bug. ***
(In reply to comment #6)
> Personally, I think I prefer thte current behavior, so I'd like to see a pref
> for this.

This might be hard to do with the floating & docking windows... I /could/ attach
a fixed input to each window, then the tabbed/docked views themselves wouldn't
have one, but it seems a bit odd.
Product: Core → Other Applications
QA Contact: samuel → chatzilla
Duplicate of this bug: 820768
You need to log in before you can comment on or make changes to this bug.