1066182 - Back out bug 768802 fix

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect, P2)

Description

[(No longer employed by Mozilla) Aaron Klotz]

Flash 15 has cleaned up the focus stealing issues that the patch from bug 768802 was intended to remedy. Let's back that patch out so that we don't suffer any unintended consequences.

Comment 1

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Backout patch

Comment 2

[Patrick Storz]

STOP!

Although I directly wrote to various people (including QA) on bug 768802 (because comments are not allowed) nobody cared.

In fact I'm afraid FlashPlayer 15 *does not* solve all issues. It might solve the issue with loosing focus, but under several circumstances (for which I will shortly open a new bug) focus is still lost temporarily or even restored to the wrong Firefox window!

I therefore hardly reccoment to *not* back out this patch, since it actually fixes all of the issues, instead of only concealing the most obvious ones as the Adobe hack in FlashPlayer 15 does.

Comment 3

[Patrick Storz]

OK, shame on me...

Fiorget everything I just said: I just got home from work so I could test the issue again and it turns out the update of flash failed the other day.

Apologies are in place for everyone I bugged because of this.

Comment 4

[Masatoshi Kimura [:emk]]

[Tracking Requested - why for this release]: The LockSetForegroundWindow() hack is not shipped yet. We should not ship it from the start.

Comment 5

[Benjamin Smedberg]

Comment on attachment 8488063 [details] [diff] [review]
Backout patch

You don't typically need review for a backout.

Comment 6

[(No longer employed by Mozilla) Aaron Klotz]

https://hg.mozilla.org/integration/mozilla-inbound/rev/81c7230eec1b

Comment 7

[(No longer employed by Mozilla) Aaron Klotz]

Comment on attachment 8488063 [details] [diff] [review]
Backout patch

Approval Request Comment
[Feature/regressing bug #]: bug 768802: The bug in Flash was fixed so I'd like to back out the brute-force approach being taken on our side.
[User impact if declined]: Potential for plugins behaving strangely due to previous patch's effects.
[Describe test coverage new/current, TBPL]: Results of patch already on beta and release.
[Risks and why]: None - a straight backout, reverts to previous behavior already on beta and release.
[String/UUID change made/needed]: None.

Comment 8

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/81c7230eec1b

Comment 9

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8488063 [details] [diff] [review]
Backout patch

Aurora+

Comment 10

[Lawrence Mandel [:lmandel] (use needinfo)]

Clearing the tracking request as we don't need to track this for release. 

(In reply to Aaron Klotz [:aklotz] from comment #7)
> [Describe test coverage new/current, TBPL]: Results of patch already on beta
> and release.

The backout has already landed on beta? Did that happen in a different bug?

Comment 11

[(No longer employed by Mozilla) Aaron Klotz]

(In reply to Lawrence Mandel [:lmandel] from comment #10)
> Clearing the tracking request as we don't need to track this for release. 
> 
> (In reply to Aaron Klotz [:aklotz] from comment #7)
> > [Describe test coverage new/current, TBPL]: Results of patch already on beta
> > and release.
> 
> The backout has already landed on beta? Did that happen in a different bug?

The original change that this backout applies to never landed on 33 in the first place.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/0b02790c64fc