Closed
Bug 1066185
Opened 11 years ago
Closed 11 years ago
TabChild needs more logging for the input events it is dealing with
Categories
(Core :: DOM: Content Processes, defect)
Tracking
()
RESOLVED
FIXED
mozilla35
People
(Reporter: kats, Assigned: kats)
Details
Attachments
(1 file)
|
3.86 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
A few times now I've had to inspect the flow of events through TabChild and used ad-hoc logging in my local build but I think it would be better to land some of it using the existing TABC_LOG macro. Patch coming in a bit.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8488070 -
Flags: review?(bugs)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8488070 [details] [diff] [review]
Trivial patch to add some logging
> bool
> TabChild::RecvHandleDoubleTap(const CSSPoint& aPoint, const ScrollableLayerGuid& aGuid)
> {
>+ TABC_LOG("Handling double tap at %s with %p %p\n",
>+ Stringify(aPoint).c_str(), mGlobal.get(), mTabChildGlobal.get());
So we don't end up executing this code in normal builds, right?
Attachment #8488070 -
Flags: review?(bugs) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
Yeah, TABC_LOG is #define'd to do nothing by default.
Keywords: checkin-needed
|
|
Assignee | |
Comment 4•11 years ago
|
||
Keywords: checkin-needed
|
||
Comment 5•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in
before you can comment on or make changes to this bug.
Description
•