Closed Bug 1066185 Opened 10 years ago Closed 10 years ago

TabChild needs more logging for the input events it is dealing with

Categories

(Core :: DOM: Content Processes, defect)

All
Gonk (Firefox OS)
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla35

People

(Reporter: kats, Assigned: kats)

Details

Attachments

(1 file)

A few times now I've had to inspect the flow of events through TabChild and used ad-hoc logging in my local build but I think it would be better to land some of it using the existing TABC_LOG macro. Patch coming in a bit.
Comment on attachment 8488070 [details] [diff] [review]
Trivial patch to add some logging


> bool
> TabChild::RecvHandleDoubleTap(const CSSPoint& aPoint, const ScrollableLayerGuid& aGuid)
> {
>+    TABC_LOG("Handling double tap at %s with %p %p\n",
>+      Stringify(aPoint).c_str(), mGlobal.get(), mTabChildGlobal.get());
So we don't end up executing this code in normal builds, right?
Attachment #8488070 - Flags: review?(bugs) → review+
Yeah, TABC_LOG is #define'd to do nothing by default.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/519d2fba6cfe
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: