Closed Bug 1066264 Opened 7 years ago Closed 7 years ago
Refactor Chief deployment script
The file could do with a cleanup to increase readability and make the execution order clearer.
This should be a no-op, but I think it makes the file much easier to follow in terms of execution order. I'd recommend looking at the individual commit diffs rather than the overall PR diff. I've left the deletion of *.pyc files in pre_update(), since it occurred to me that since commander is called three times (once for each of pre_update, update and deploy), the second and third times will pick up future changes to update.py for free, since the script is loaded again from disk (ie: avoiding the broken update.py scenario we talked about earlier, so long as pre_update itself works). However this will only work if pre_update removes the pyc files (as opposed to it being done in update() with the other compile type tasks).
Attachment #8488267 - Flags: review?(jeads)
Summary: Refactor Chief update.py → Refactor Chief deployment script
Comment on attachment 8488267 [details] [review] Refactor update.py This is much better, way easier to read. Thank you
Attachment #8488267 - Flags: review?(jeads) → review+
Commits pushed to master at https://github.com/mozilla/treeherder-service https://github.com/mozilla/treeherder-service/commit/cfef06799b6a76220dfa08f91b5d7c427de3ebbd Bug 1066264 - Refactor update.py: Move contents of pre_update() inline https://github.com/mozilla/treeherder-service/commit/d5f31ced1db94852d601de733b849e42f09d4112 Bug 1066264 - Refactor update.py: Move contents of update() inline https://github.com/mozilla/treeherder-service/commit/c207c0594e79ad56911585804f0700c17e5941f9 Bug 1066264 - Refactor update.py: Clean up comments https://github.com/mozilla/treeherder-service/commit/7f011e09ae63380efc5f2b1fa55751a971cf12c7 Bug 1066264 - Refactor update.py: Move contents of deploy() inline https://github.com/mozilla/treeherder-service/commit/f5793c48ef2ba420839d085abe642a3f36c29785 Bug 1066264 - Refactor update.py: Remove unnecessary wrapping https://github.com/mozilla/treeherder-service/commit/a3898e1354f7793ec6871570c0329a21e3a579a2 Merge pull request #214 from mozilla/deploy-script-refactor Bug 1066264 - Refactor update.py
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.