Closed Bug 1066264 Opened 7 years ago Closed 7 years ago

Refactor Chief deployment script

Categories

(Tree Management :: Treeherder, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: emorley, Assigned: emorley)

Details

Attachments

(1 file)

54 bytes, text/x-github-pull-request
jeads
: review+
Details | Review
The file could do with a cleanup to increase readability and make the execution order clearer.
Attached file Refactor update.py
This should be a no-op, but I think it makes the file much easier to follow in terms of execution order. I'd recommend looking at the individual commit diffs rather than the overall PR diff.

I've left the deletion of *.pyc files in pre_update(), since it occurred to me that since commander is called three times (once for each of pre_update, update and deploy), the second and third times will pick up future changes to update.py for free, since the script is loaded again from disk (ie: avoiding the broken update.py scenario we talked about earlier, so long as pre_update itself works). However this will only work if pre_update removes the pyc files (as opposed to it being done in update() with the other compile type tasks).
Attachment #8488267 - Flags: review?(jeads)
Summary: Refactor Chief update.py → Refactor Chief deployment script
Priority: -- → P3
Comment on attachment 8488267 [details] [review]
Refactor update.py

This is much better, way easier to read. Thank you
Attachment #8488267 - Flags: review?(jeads) → review+
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.