Closed Bug 1066299 Opened 9 years ago Closed 9 years ago

Height is wrong in landscape cards view with SHB

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

x86
macOS
defect
Not set
normal

Tracking

(b2g-v2.0 unaffected, b2g-v2.1 unaffected, b2g-v2.2 verified)

VERIFIED FIXED
2.1 S4 (12sep)
Tracking Status
b2g-v2.0 --- unaffected
b2g-v2.1 --- unaffected
b2g-v2.2 --- verified

People

(Reporter: kgrandon, Assigned: kgrandon)

References

Details

(Whiteboard: [systemsfe])

Attachments

(1 file)

46 bytes, text/x-github-pull-request
Eli
: review+
Details | Review
      No description provided.
Attached file Github pull request
Could one of you guys give this a quick review? Thanks!
Attachment #8488218 - Flags: review?(sfoster)
Attachment #8488218 - Flags: review?(eperelman)
Could we land bug 1059967 before this and update this patch to use `var(--software-home-button-height)`?
(In reply to :Eli Perelman from comment #2)
> Could we land bug 1059967 before this and update this patch to use
> `var(--software-home-button-height)`?

Sure, that sounds good. It looks like that one has an R+, so let's land and rebase. Thanks!
That bug has checkin-needed, just waiting for the commit to happen.
Thanks. I've landed bug 1059967 and am rebasing now.
Depends on: 1059967
Patch is rebased now. <3 these CSS vars even if the syntax is awful looking.
Comment on attachment 8488218 [details] [review]
Github pull request

Looks good to me.
Attachment #8488218 - Flags: review?(eperelman) → review+
I think I am blocking the wrong bug here.
Blocks: 1061324
No longer blocks: 1047143
Comment on attachment 8488218 [details] [review]
Github pull request

Thanks for looking to both of you guys. I'm fine with landing this with Eli's review for now. Cheers.
Attachment #8488218 - Flags: review?(sfoster)
Since linters are green and the patch is simple, landing:https://github.com/mozilla-b2g/gaia/commit/63155ffa1132ce2022ba4e0e97793a09ea82e4ec
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Verified as fixed for the latest 2.2 Flame build:

Enviromental Variables:
----------------------------------------
Device: Flame 2.2 Master
BuildID: 20140916040203
Gaia: e2d70bee03b5380ac327a145e5d694fb2443f018
Gecko: 3b7921328fc1
Version: 35.0a1 (2.2 Master)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Comparing the difference between the 9/11 build and today's build, the SHB is reflecting the desired changes.
Status: RESOLVED → VERIFIED
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(pbylenga)
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(pbylenga)
You need to log in before you can comment on or make changes to this bug.