Closed Bug 1066320 Opened 5 years ago Closed 5 years ago

Crop lightweight theme image if it's larger than the displayable area

Categories

(Firefox for Android :: General, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 35

People

(Reporter: rnewman, Assigned: manu.jain13, Mentored)

References

(Blocks 1 open bug)

Details

(Keywords: perf, Whiteboard: [good first bug][lang=java])

Attachments

(1 file)

This might be a nice little memory win for large themes. See Bug 1065490 for discussion.
I would like to give this bug a try. I'm currently a University Student and might need some guidance since I am new to Mozilla Development. Would you suggest this bug?
vdmannvol - This is a good started bug, so give it a try. You'll need to get set up to build Firefox for Android first. This is a good place to get started:

https://developer.mozilla.org/en-US/docs/Introduction
Attached patch bug1066320.patchSplinter Review
Is the patch correct, or should I make more changes.
Attachment #8488957 - Flags: review?(rnewman)
Comment on attachment 8488957 [details] [diff] [review]
bug1066320.patch

I tested the patch on a phone and a 7" tablet, installing a theme and then rotating between portrait and landscape. It worked OK for me.

I removed the need for the local | croplarge | variable and I made it a single line.
Attachment #8488957 - Flags: review?(rnewman) → review+
Ok, so are the tests passed?
(In reply to manu.jain13 from comment #6)
> Ok, so are the tests passed?

We only have manual testing for Lightweight themes :(, which is I why did the manual tests on a phone and tablet.
So, is it resolved or is their any further modifications needed?
And also "Assigned to" field is still showing "Nobody".
Can you assign this to me. Thanks!!
(In reply to manu.jain13 from comment #8)
> So, is it resolved or is their any further modifications needed?
> And also "Assigned to" field is still showing "Nobody".
> Can you assign this to me. Thanks!!

Yes. This is finished. Thanks for the patch!
Assignee: nobody → manu.jain13
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/4c0b9148640b
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
You need to log in before you can comment on or make changes to this bug.