1066324 - "Unknown repository" error is briefly shown on initial load of Treeherder.

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P1)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Attachment: Don't do that

When you first load treeherder, the URL has not yet redirected to the default (mozilla-central) repository, so the ng-show check for the repository's URL is failing, causing the "Unknown repo" error to be displayed for a split second.

Comment 1

[Ed Morley [:emorley]]

https://github.com/mozilla/treeherder-ui/commit/da5eb72cf12c3a30ac6e35941bb3a316d6f193e8

Comment 2

[Ed Morley [:emorley]]

This is still happening when I visit http://treeherder-dev.allizom.org/

Not a massive issue per se, but just gives an unfortunate first impression to people using treeherder for the first time :-)

Comment 3

[Ed Morley [:emorley]]

Wes, do you know if you'll have a chance to look at this today or Monday?
Or I can open a new bug and see if one of the others wants to take a look if that works for you? :-)

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I'll try to get to it on Monday, but I wouldn't be opposed to this splitting off to a new bug if someone else really wants to take it.

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I'm not sure what's going on here.
As far as I can tell, the unknown repository error should only be shown when all of the following conditions are true:
1. 0 resultsets have been returned
2. We are not appending more resultsets
3. We are not loading jobs
4. There is no "revision" search parameter
5. There is a "repo" search parameter
6. The current repo's designated URL is unknown.



I only see the unknown repository error on initially loading treeherder. (So the address will be [treeherderRoot]/ui or [treeherderRoot]/ui/ or [treeherderRoot]/ui/#/jobs )

The error goes away once Treeherder redirects to the default mozilla-central repository (So the address will now be [treeherderRoot]/ui/#/jobs?repo=mozilla-central )

At the point where the error is shown, condition 1 and 4 should be true, while conditions 5 and 6 are false. (I'm unsure exactly when 2 and 3 switch between true and false.)


I don't know enough about Angular to figure out why it's still being shown when not all of the conditions are being met (or why Angular believes all of the conditions are being met).

Comment 6

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/a1d6d323882930d57b52a9631175f6acea49c49e
bug 1066324 and bug 1074539 - bad page reload gives error

https://github.com/mozilla/treeherder-ui/commit/d1397c3cda3cb45b6ca0bc82ee94a515407e843e
Merge pull request #213 from mozilla/bug-1074539-reload-on-redirect

bug 1066324 and bug 1074539 - bad page reload gives error

Comment 7

[Cameron Dawson [:camd]]

pushed to dev and stage now

Comment 8

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/29143afd6cb616319f6007d7c51bd0f1412c65a3
bug 1066324 and bug 1074539 - bad page reload gives error

https://github.com/mozilla/treeherder/commit/dd869ae2a482e2d483b5dcf389f3d1cf5afa0b87
Merge pull request #213 from mozilla/bug-1074539-reload-on-redirect

bug 1066324 and bug 1074539 - bad page reload gives error