1066332 - [traceback] ValueError: The __year lookup type requires an integer argument /reports/rep/pierros/?year=%2527&month=March throws a 500 Internal Server Error

Status: VERIFIED FIXED

(Mozilla Reps Graveyard :: reps.mozilla.org, task)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: reps-500.png

STR:

Load https://reps-dev.allizom.org/reports/rep/pierros/?year=%2527&month=March

Actual:

Throws a 500; sorry, but I don't have the Python exception/stacktrace handy -- it's not in New Relic, that I can see:

https://rpm.newrelic.com/accounts/263620/applications/3650909/traced_errors

Comment 1

[John Giannelos [:nemo-yiannis]]

Here is the traceback:

Traceback (most recent call last):

  File "/data/www/reps-dev.allizom.org/remo/vendor/lib/python/django/core/handlers/base.py", line 113, in get_response
    response = callback(request, *callback_args, **callback_kwargs)

  File "/data/www/reps-dev.allizom.org/remo/remo/reports/views.py", line 210, in list_ng_reports
    report_date__month=month)

  File "/data/www/reps-dev.allizom.org/remo/vendor/lib/python/django/db/models/query.py", line 669, in filter
    return self._filter_or_exclude(False, *args, **kwargs)

  File "/data/www/reps-dev.allizom.org/remo/vendor/lib/python/django/db/models/query.py", line 687, in _filter_or_exclude
    clone.query.add_q(Q(*args, **kwargs))

  File "/data/www/reps-dev.allizom.org/remo/vendor/lib/python/django/db/models/sql/query.py", line 1271, in add_q
    can_reuse=used_aliases, force_having=force_having)

  File "/data/www/reps-dev.allizom.org/remo/vendor/lib/python/django/db/models/sql/query.py", line 1202, in add_filter
    connector)

  File "/data/www/reps-dev.allizom.org/remo/vendor/lib/python/django/db/models/sql/where.py", line 71, in add
    value = obj.prepare(lookup_type, value)

  File "/data/www/reps-dev.allizom.org/remo/vendor/lib/python/django/db/models/sql/where.py", line 339, in prepare
    return self.field.get_prep_lookup(lookup_type, value)

  File "/data/www/reps-dev.allizom.org/remo/vendor/lib/python/django/db/models/fields/__init__.py", line 730, in get_prep_lookup
    return super(DateField, self).get_prep_lookup(lookup_type, value)

  File "/data/www/reps-dev.allizom.org/remo/vendor/lib/python/django/db/models/fields/__init__.py", line 329, in get_prep_lookup
    raise ValueError("The __year lookup type requires an integer "

ValueError: The __year lookup type requires an integer argument

Comment 2

[[github robot]]

Commits pushed to master at https://github.com/mozilla/remo

https://github.com/mozilla/remo/commit/840736903c856bcfb95c446898600ae094f41023
[fix bug 1066332] Ensure that year var in reports is always a number.

https://github.com/mozilla/remo/commit/e1c75f1d687b10dddf42f8b10ee5510e4b658a17
Merge pull request #816 from akatsoulas/1066332

[fix bug 1066332] Ensure that year var in reports is always a number.

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

Awesome, thanks -- verified FIXED, as this now returns a 404 on dev.