Closed Bug 1066339 Opened 10 years ago Closed 10 years ago

Use CSS variables for statusbar height

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::System
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-v2.1 fixed, b2g-v2.2 fixed)

Status:
RESOLVED FIXED
Milestone:
2.1 S5 (26sep)
Tracking Flags:
Tracking Status
b2g-v2.1 --- fixed
b2g-v2.2 --- fixed

People

(Reporter: kgrandon, Assigned: kgrandon)

References

Details

(Whiteboard: [systemsfe])

Attachments

(1 file)

Github pull request
46 bytes, text/x-github-pull-request
alive
: review+
fabrice
: approval-gaia-v2.1+
Details | Review 
Now that bug 1059967 has landed and we have some initial direction for using CSS variables, we should consider using them for the statusbar heights and other dimensions if it would be useful.
Attached file Github pull request — 
Alive or Vivien - could one of you guys review this? Just need one review, but not sure who is more busy. Feel free to clear the other review if you get to this first. Thanks!
Attachment #8488274 - Flags: review?(alive)
Attachment #8488274 - Flags: review?(21)
Comment on attachment 8488274 [details] [review]
Github pull request

r=me
Attachment #8488274 - Flags: review?(alive)
Attachment #8488274 - Flags: review?(21)
Attachment #8488274 - Flags: review+
Master: https://github.com/mozilla-b2g/gaia/commit/0f45989dfa25d15ad3d6e0bef41847e46d0da774
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [systemsfe]
Target Milestone: --- → 2.1 S4 (12sep)
Blocks: 1060577
Comment on attachment 8488274 [details] [review]
Github pull request

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Engineering code clean-up.
[User impact] if declined: We're trying to land visual polish and fixes that conflict with this. Having different base code like this is risky when we have uplift conflicts which may cause regressions or issues debugging in the future.
[Testing completed]: Manual testing and this has been baking in master for a while.
[Risk to taking this patch] (and alternatives if risky): Low risk as it's been in master for ~2 weeks.
[String changes made]: No.
Attachment #8488274 - Flags: approval-gaia-v2.1?(fabrice)
No longer blocks: 1060577
Blocks: 1054778
Attachment #8488274 - Flags: approval-gaia-v2.1?(fabrice) → approval-gaia-v2.1+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: