1066347 - Separate concatenated l10n JSON per HTML file

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::L10n, defect, P3)

Description

[Zibi Braniecki [:zbraniecki][:gandalf]]

We currently build a single ab-CD.json per app. Apps have multiple files with different resources required.

We should build one ab-CD-file.json per HTML file.

Comment 1

[Staś Małolepszy :stas]

It might be worth checking how many strings are shared between each HTML file and if there are many, creating a {locale}-common.json file to avoid duplication of strings in per-file JSONs.

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: pull request

Comment 3

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8590149 [details] [review]
pull request

Ok, the patch is ready.

Stas, can you review it first? Once you're happy, I'll ask :rickychien.

I took liberty to clean up some pieces as I moved writeAST to HTMLOptimizer, especially around HTMLOptimizer's callback that has not been used at all.
The code is leaner which I like and should be less racey.

Comment 4

[Staś Małolepszy :stas]

Comment on attachment 8590149 [details] [review]
pull request

I like that fact that this both makes more sense *and* make the code simpler :)  webapp.asts was a useless abstraction. r=me, thanks!

Comment 5

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8590149 [details] [review]
pull request

Ricky?

Comment 6

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8590149 [details] [review]
pull request

Hi there are some nits I leaved on Github, please fix it and r=me thanks!

Comment 7

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/6e403dbb863fb9ec41bd22b6583e2eff5045d78b

Comment 8

[Staś Małolepszy :stas]

We'll need to fix the langpack builder to use the same file names for JSONs: https://github.com/zbraniecki/langpack-builder/pull/5