Intermittent browser_967000_button_sync.js | Firefox Sync page opened with `menupanel` entrypoint - Got about:blank, expected about:accounts?entrypoint=uitour

RESOLVED FIXED in Firefox 35

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: RyanVM, Assigned: Gijs)

Tracking

({intermittent-failure})

unspecified
Firefox 35
x86_64
Mac OS X
intermittent-failure
Points:
1
Bug Flags:
firefox-backlog +
in-testsuite +
qe-verify -

Firefox Tracking Flags

(firefox33 unaffected, firefox34 unaffected, firefox35 fixed, firefox-esr31 unaffected)

Details

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
https://tbpl.mozilla.org/php/getParsedLog.php?id=47920083&tree=Mozilla-Inbound

Rev5 MacOSX Mountain Lion 10.8 mozilla-inbound debug test mochitest-browser-chrome-1 on 2014-09-11 15:11:42 PDT for push 3a582ed49923
slave: talos-mtnlion-r5-062

15:31:00     INFO -  831 INFO checking window state
15:31:00     INFO -  832 INFO Entering test
15:31:00     INFO -  833 INFO Check Sync button functionality
15:31:00     INFO -  834 INFO TEST-PASS | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_967000_button_sync.js | The Sync button was added to the Panel Menu
15:31:00     INFO -  835 INFO Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element '-webkit-search-cancel-button'.  Ruleset ignored due to bad selector." {file: "chrome://browser/content/aboutaccounts/normalize.css" line: 366 column: 22 source: "input[type="search"]::-webkit-search-cancel-button,"}]
15:31:00     INFO -  836 INFO Console message: [JavaScript Warning: "Error in parsing value for 'min-height'.  Declaration dropped." {file: "chrome://browser/content/aboutaccounts/main.css" line: 125 column: 16 source: "    min-height: none;"}]
15:31:00     INFO -  837 INFO Console message: [JavaScript Warning: "Expected media feature name but found 'min-device-pixel-ratio'." {file: "chrome://browser/content/aboutaccounts/main.css" line: 144 column: 17 source: "only screen and (min-device-pixel-ratio: 2),"}]
15:31:00     INFO -  838 INFO TEST-PASS | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_967000_button_sync.js | Firefox Sync page opened with `menupanel` entrypoint
15:31:00     INFO -  839 INFO TEST-PASS | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_967000_button_sync.js | The panel closed
15:31:00     INFO -  840 INFO Leaving test
15:31:00     INFO -  841 INFO Entering test asyncCleanup
15:31:00     INFO -  842 INFO TEST-PASS | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_967000_button_sync.js | The panel UI is in default state again.
15:31:00     INFO -  843 INFO Leaving test asyncCleanup
15:31:00     INFO -  844 INFO Entering test
15:31:00     INFO -  845 INFO Check Sync button functionality
15:31:00     INFO -  846 INFO TEST-PASS | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_967000_button_sync.js | The Sync button was added to the Panel Menu
15:31:00     INFO -  847 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_967000_button_sync.js | Firefox Sync page opened with `menupanel` entrypoint - Got about:blank, expected about:accounts?entrypoint=uitour
15:31:00     INFO -  Stack trace:
15:31:00     INFO -      chrome://mochikit/content/browser-test.js:test_is:793
15:31:00     INFO -      chrome://mochitests/content/browser/browser/components/customizableui/test/browser_967000_button_sync.js:openAboutAccountsFromMenuPanel:43
15:31:00     INFO -      Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:865:23
15:31:00     INFO -      this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:744:7
15:31:00     INFO -  ++DOCSHELL 0x130aeb000 == 52 [pid = 1266] [id = 1736]
15:31:00     INFO -  ++DOMWINDOW == 150 (0x126d5b800) [pid = 1266] [serial = 4706] [outer = 0x0]
15:31:00     INFO -  ++DOMWINDOW == 151 (0x128d99000) [pid = 1266] [serial = 4707] [outer = 0x126d5b800]
15:31:00     INFO -  [Parent 1266] WARNING: NS_ENSURE_TRUE(mMutable) failed: file /builds/slave/m-in-osx64-d-00000000000000000/build/netwerk/base/src/nsSimpleURI.cpp, line 265
15:31:00     INFO -  [Parent 1266] WARNING: NS_ENSURE_SUCCESS(EnsureScriptEnvironment(), nullptr) failed with result 0x80040111: file /builds/slave/m-in-osx64-d-00000000000000000/build/docshell/base/nsDocShell.cpp, line 4371
15:31:00     INFO -  [Parent 1266] WARNING: NS_ENSURE_SUCCESS(EnsureScriptEnvironment(), nullptr) failed with result 0x80040111: file /builds/slave/m-in-osx64-d-00000000000000000/build/docshell/base/nsDocShell.cpp, line 4371
15:31:00     INFO -  848 INFO TEST-OK | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_967000_button_sync.js | took 993ms
(Assignee)

Comment 1

4 years ago
This is almost certainly the fault of the bug that introduced the entrypoint thingymajig, considering this test has been running smoothly right up to that point...
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
(Assignee)

Updated

4 years ago
Blocks: 1053939
(Assignee)

Comment 5

4 years ago
This bug is so nice, I blogged about it a year ago. :-)

http://www.gijsk.com/blog/2013/05/you-dont-know-what-youve-got-till-its-gone-or-tab-load-detection-gone-wrong/

Patch upcoming.
(Assignee)

Comment 6

4 years ago
Created attachment 8488555 [details] [diff] [review]
fix intermittent load events in browser_967000_button_sync.js,

Added in a check for the about:blank load like we have in most of our promiseTabLoad incantations, too.
Attachment #8488555 - Flags: review?(mhammond)
(Assignee)

Updated

4 years ago
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
(Assignee)

Comment 7

4 years ago
Marco, can you add this? Thanks!
Iteration: --- → 35.1
Points: --- → 1
Flags: qe-verify-
Flags: needinfo?(mmucci)
Flags: in-testsuite+
Flags: firefox-backlog+
Added to IT 35.1

(In reply to :Gijs Kruitbosch from comment #7)
> Marco, can you add this? Thanks!
Flags: needinfo?(mmucci)
(In reply to :Gijs Kruitbosch from comment #5)
> This bug is so nice, I blogged about it a year ago. :-)
> 
> http://www.gijsk.com/blog/2013/05/you-dont-know-what-youve-got-till-its-gone-
> or-tab-load-detection-gone-wrong/
> 
> Patch upcoming.

Doh - that's my fault!  Thanks!

Updated

4 years ago
Attachment #8488555 - Flags: review?(mhammond) → review+
(Assignee)

Comment 10

4 years ago
(In reply to Mark Hammond [:markh] from comment #9)
> (In reply to :Gijs Kruitbosch from comment #5)
> > This bug is so nice, I blogged about it a year ago. :-)
> > 
> > http://www.gijsk.com/blog/2013/05/you-dont-know-what-youve-got-till-its-gone-
> > or-tab-load-detection-gone-wrong/
> > 
> > Patch upcoming.
> 
> Doh - that's my fault!  Thanks!

Nah, no worries - similar code lived in the tree for aeons. It's our own fault we don't have a comprehensive set of utility functions for this kind of thing.

remote:   https://hg.mozilla.org/integration/fx-team/rev/9f4de6f4b71b
Whiteboard: [fixed-in-fx-team]
(In reply to :Gijs Kruitbosch from comment #5)
> This bug is so nice, I blogged about it a year ago. :-)
> 
> http://www.gijsk.com/blog/2013/05/you-dont-know-what-youve-got-till-its-gone-
> or-tab-load-detection-gone-wrong/
> 
> Patch upcoming.

Thank you Gijs for taking care of it. I didn't know that, but I'm glad I found about your blog with this bug :-).
https://hg.mozilla.org/mozilla-central/rev/9f4de6f4b71b
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 35
(Reporter)

Updated

4 years ago
status-firefox33: --- → unaffected
status-firefox34: --- → unaffected
status-firefox35: --- → fixed
status-firefox-esr31: --- → unaffected
You need to log in before you can comment on or make changes to this bug.