Closed Bug 1066425 Opened 7 years ago Closed 7 years ago

GMPDecryptorChild callbacks should be threadsafe

Categories

(Core :: Audio/Video, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla35

People

(Reporter: eflores, Assigned: eflores)

References

Details

Attachments

(1 file)

Currently the GMPDecryptorChild methods for the GMPDecryptorCallback interface check that they are being called on the GMP thread; this doesn't make any sense if the plugin does any async processing.
Attachment #8488408 - Flags: review?(cpearce)
Comment on attachment 8488408 [details] [diff] [review]
decryptorchild-threading.patch

Review of attachment 8488408 [details] [diff] [review]:
-----------------------------------------------------------------

Nice, but for consistency we should also do the other callback objects too; the GMPAudioDecoderCallback, GMPVideoDecoderCallback, and GMPVideoEncoderCallback.

Please add a comment to gmp-decryption.h above GMPDecryptorCallback that it is threadsafe.
Attachment #8488408 - Flags: review?(cpearce) → review+
(In reply to Chris Pearce (:cpearce) from comment #1)
> Comment on attachment 8488408 [details] [diff] [review]
> decryptorchild-threading.patch
> 
> Review of attachment 8488408 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Nice, but for consistency we should also do the other callback objects too;
> the GMPAudioDecoderCallback, GMPVideoDecoderCallback, and
> GMPVideoEncoderCallback.

Just so we're clear, this should be done in a separate bug.
https://hg.mozilla.org/mozilla-central/rev/4db41aa61692
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in before you can comment on or make changes to this bug.