1066425 - GMPDecryptorChild callbacks should be threadsafe

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Edwin Flores [inactive from 2016-12-01] [:eflores] [:edwin]]

Attachment: decryptorchild-threading.patch

Currently the GMPDecryptorChild methods for the GMPDecryptorCallback interface check that they are being called on the GMP thread; this doesn't make any sense if the plugin does any async processing.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8488408 [details] [diff] [review]
decryptorchild-threading.patch

Review of attachment 8488408 [details] [diff] [review]:
-----------------------------------------------------------------

Nice, but for consistency we should also do the other callback objects too; the GMPAudioDecoderCallback, GMPVideoDecoderCallback, and GMPVideoEncoderCallback.

Please add a comment to gmp-decryption.h above GMPDecryptorCallback that it is threadsafe.

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

(In reply to Chris Pearce (:cpearce) from comment #1)
> Comment on attachment 8488408 [details] [diff] [review]
> decryptorchild-threading.patch
> 
> Review of attachment 8488408 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Nice, but for consistency we should also do the other callback objects too;
> the GMPAudioDecoderCallback, GMPVideoDecoderCallback, and
> GMPVideoEncoderCallback.

Just so we're clear, this should be done in a separate bug.

Comment 3

[Edwin Flores [inactive from 2016-12-01] [:eflores] [:edwin]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4db41aa61692

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4db41aa61692