1066446 - [Ringtones][Music]Both ringtones & music play at the same time

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: General, defect)

Description

[ankit93040]

User Agent: Mozilla/5.0 (Windows NT 6.1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/37.0.2062.120 Safari/537.36

Steps to reproduce:

1. Go to music & play a song.
2. Pause the song.
3. Click on share -> Ringtones
4. In create ringtone screen, play the tone by pressing play button
5. Notification(statusbar) area scroll down.
6. Play the music.


Actual results:

music plays from both create ringtone screen & music app


Expected results:

It should play from only music

Comment 1

[Jim Porter (:squib)]

Yeah, that's about what I'd expect to happen, since we use a weird hack to pause the music app. This will probably be fixed when we rewrite the audio competition code, but luckily this is a really narrow edge case, so I don't think this would block a release.

Comment 2

[ankit93040]

Hi Dominic

Please see this.. Jim told that you are the right one for this.

Thanks

Comment 3

[ankit93040]

Hi Alive

there is a way to resolve this, obviously at the cost of other things.
  i.> Lets stop the user from descending down the Utility tray (status bar). 
    It doesn't look good at all.
 ii.> whenever user scrolls down the Utility tray (status bar) & if he is in ringtone app, lets close the activity.
     I don't know how system app can close an activty forcibly? so couldn't try this.

What do you say. second one sounds reasonable.

Alive, whats your opinion on this. Will it have any defect on the system or crash?

Thanks!

Comment 4

[Dominic Kuo [:dkuo]]

(In reply to ankit93040 from comment #2)
> Hi Dominic
> 
> Please see this.. Jim told that you are the right one for this.
> 
> Thanks

Jim is correct in comment 1, it's because both music and ringtones apps are visible(document.hidden is false) so those two channels(ringer and content) are able to play sounds at the same time. Currently I think we are unable to fix this without a hack, like we already did for the music and ringtones apps. Also I agree this should not be a blocker cause it's such an edge case.

Comment 5

[ankit93040]

Hi Wayne

Greetings!

Please do something for this.
It's a blocker for us.

Thanks a lot.

Comment 6

[Wayne Chang [:wchang]]

I also don't see this as a blocker given the steps and it's use case.

Comment 7

[Jim Porter (:squib)]

(In reply to Dominic Kuo [:dkuo] from comment #4)
> Jim is correct in comment 1, it's because both music and ringtones apps are
> visible(document.hidden is false) so those two channels(ringer and content)
> are able to play sounds at the same time. Currently I think we are unable to
> fix this without a hack, like we already did for the music and ringtones
> apps. Also I agree this should not be a blocker cause it's such an edge case.

We might (emphasis on "might") be able to extend our hack to work a bit like what happens when you're on a phone call: disable the ability for music to play until the ringtone creation activity ends. I'd rather not do that though, since if things go wrong, the music app will be broken until you kill and restart it. Even so, there are probably other weird things you'd be able to do to subvert this.

Comment 8

[ankit93040]

Dear Vance

Greetings!

We need your kind help on this. Please if you can assign this to somebody as it is a blocker for us(v2.0).

Thanks

Regards
Ankit

Comment 9

[ranjith253]

Hi Dominic,

How about using same hack for ringtone app which is used in music app for pausing.
Music app will set the hack properties & ringtone app will listen for it for pausing ringtone.

Thanks.

Comment 10

[ranjith253]

Attachment: WIP

Hi,

I am adding  WIP for my approach in comment 9.
Thanks,

Comment 11

[Dominic Kuo [:dkuo]]

Comment on attachment 8497482 [details]
WIP

I prefer not to land some similar hacks on master unless this bug become a blocker.

Comment 12

[Jim Porter (:squib)]

Comment on attachment 8497482 [details]
WIP

I don't think this is the right way to go about this. I think it makes a lot more sense for the music to be locked in a "paused" state until ringtone selection is done.

Also, like Dominic said, I strongly oppose any more hacks added to this part of the code unless this bug gets marked as a blocker, so please request blocking first. However, I disagree that this is a blocker in the first place, since it's a rarely-encountered edge case that doesn't actually *break* anything. Still, if you can convince project management that this is a blocker, I'm willing to hold my nose and land a patch to fix this.

I'd very much prefer that we fix this as a part of the audio competition rework. I'm not sure how that's progressing, but perhaps Dominic knows, since I believe he was working on it in the past.

(Finally, I imagine a lot of this is going to change when Dominic lands his work to split up the music app into two pieces.)

Comment 13

[Jim Porter (:squib)]

This doesn't happen anymore, thanks to changes to the AudioChannel code.