1066447 - Make cloudsync test work in e10s

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: fix-cloudsync

The cloudsync test is running in e10s now, but it turns out that it's not doing anything because the page it's testing with is a chrome:// URL. With the patch in bug 1059007, these URLs become remote.

The problem is pretty clearly shown in the patch. I know that we have an eventual goal of having private tabs, so I added a call that will allow us to make the transition a little more easily while still staying compatible with e10s.

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 8488442 [details] [diff] [review]
fix-cloudsync

Review of attachment 8488442 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/modules/PrivateBrowsingUtils.jsm
@@ +21,2 @@
>    isWindowPrivate: function pbu_isWindowPrivate(aWindow) {
>      return this.privacyContextFromWindow(aWindow).usePrivateBrowsing;

We could throw an error here when a content window is passed I assume? We will always want a XUL window.

@@ +23,5 @@
>    },
>  
> +  isBrowserPrivate: function(aBrowser) {
> +    return this.isWindowPrivate(aBrowser.ownerDocument.defaultView);
> +  },

Should use that too for SessionStore once it reports the correct value for a given browser. So we didn't have to collect data twice.

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

(In reply to Tim Taubert [:ttaubert] from comment #1)
> Comment on attachment 8488442 [details] [diff] [review]
> fix-cloudsync
> 
> Review of attachment 8488442 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: toolkit/modules/PrivateBrowsingUtils.jsm
> @@ +21,2 @@
> >    isWindowPrivate: function pbu_isWindowPrivate(aWindow) {
> >      return this.privacyContextFromWindow(aWindow).usePrivateBrowsing;
> 
> We could throw an error here when a content window is passed I assume? We
> will always want a XUL window.

I filed bug 1069059 to more thoroughly address this.

Comment 3

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6990e9c3e88e

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6990e9c3e88e