Closed
Bug 1066447
Opened 11 years ago
Closed 11 years ago
Make cloudsync test work in e10s
Categories
(Firefox :: Sync, defect)
Tracking
()
RESOLVED
FIXED
mozilla35
Tracking | Status | |
---|---|---|
e10s | + | --- |
People
(Reporter: billm, Assigned: billm)
Details
Attachments
(1 file)
1.99 KB,
patch
|
ttaubert
:
review+
|
Details | Diff | Splinter Review |
The cloudsync test is running in e10s now, but it turns out that it's not doing anything because the page it's testing with is a chrome:// URL. With the patch in bug 1059007, these URLs become remote.
The problem is pretty clearly shown in the patch. I know that we have an eventual goal of having private tabs, so I added a call that will allow us to make the transition a little more easily while still staying compatible with e10s.
Attachment #8488442 -
Flags: review?(ttaubert)
Comment 1•11 years ago
|
||
Comment on attachment 8488442 [details] [diff] [review]
fix-cloudsync
Review of attachment 8488442 [details] [diff] [review]:
-----------------------------------------------------------------
::: toolkit/modules/PrivateBrowsingUtils.jsm
@@ +21,2 @@
> isWindowPrivate: function pbu_isWindowPrivate(aWindow) {
> return this.privacyContextFromWindow(aWindow).usePrivateBrowsing;
We could throw an error here when a content window is passed I assume? We will always want a XUL window.
@@ +23,5 @@
> },
>
> + isBrowserPrivate: function(aBrowser) {
> + return this.isWindowPrivate(aBrowser.ownerDocument.defaultView);
> + },
Should use that too for SessionStore once it reports the correct value for a given browser. So we didn't have to collect data twice.
Attachment #8488442 -
Flags: review?(ttaubert) → review+
Assignee | ||
Comment 2•11 years ago
|
||
(In reply to Tim Taubert [:ttaubert] from comment #1)
> Comment on attachment 8488442 [details] [diff] [review]
> fix-cloudsync
>
> Review of attachment 8488442 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> ::: toolkit/modules/PrivateBrowsingUtils.jsm
> @@ +21,2 @@
> > isWindowPrivate: function pbu_isWindowPrivate(aWindow) {
> > return this.privacyContextFromWindow(aWindow).usePrivateBrowsing;
>
> We could throw an error here when a content window is passed I assume? We
> will always want a XUL window.
I filed bug 1069059 to more thoroughly address this.
Assignee | ||
Comment 3•11 years ago
|
||
Updated•11 years ago
|
tracking-e10s:
--- → +
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Updated•7 years ago
|
Component: Firefox Sync: UI → Sync
Product: Cloud Services → Firefox
You need to log in
before you can comment on or make changes to this bug.
Description
•