Closed
Bug 1066469
Opened 10 years ago
Closed 10 years ago
Highlighting of lines doesn't work in sample anymore
Categories
(developer.mozilla.org Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: teoli, Unassigned)
Details
(Whiteboard: [specification][type:bug])
What did you do?
================
1. Go to https://developer.mozilla.org/en-US/docs/Web/API/AudioBuffer
2. Look at the source for the highlighted sample, you see:
<pre class="brush: js;highlight[7,14,27]">
What happened?
==============
Nothing
What should have happened?
==========================
line 7, 14 and 27 should have been highlighted.
Is there anything else we should know?
======================================
This was working before, it is a regression. It was a major feature that we set as a condition for migrating to the new highlighter.
Comment 1•10 years ago
|
||
I have a pull request in for this:
https://github.com/mozilla/kuma/pull/2742
The highlight piece should be "highlight:[1, 2, 3]" but I've made the parse more forgiving.
Reporter | ||
Comment 2•10 years ago
|
||
Oh! Not including the column was an error. (Read the code too quickly)
Thank for the forgiveness improvement though.
So it wasn't a regression!
Comment 3•10 years ago
|
||
Commits pushed to master at https://github.com/mozilla/kuma
https://github.com/mozilla/kuma/commit/af44b87de44689b8bf47f413d185785fed337fe7
fix bug 1066469 - Allow looser highlighting syntax
https://github.com/mozilla/kuma/commit/821762f2e2385e14bee6c4b8805a18914be82102
Merge pull request #2742 from darkwing/syntax-highlight
fix bug 1066469 - Allow looser highlighting syntax
Updated•10 years ago
|
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•4 years ago
|
Product: developer.mozilla.org → developer.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•